The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: jamespetts on January 31, 2014, 11:11:55 PM

Title: GUI colours to follow selected player not default player
Post by: jamespetts on January 31, 2014, 11:11:55 PM
May I suggest that the colours of elements of the GUI that are in player colour be based on the colour of the currently selected player rather than the default player?
Title: Re: GUI colours to follow selected player not default player
Post by: Ters on January 31, 2014, 11:35:05 PM
Which elements? And by default player color, do you mean the "playerless" color (orange)?
Title: Re: GUI colours to follow selected player not default player
Post by: jamespetts on January 31, 2014, 11:39:56 PM
Ahh, no, apologies for not being clear: I mean GUI menu buttons which use the player colour.
Title: Re: GUI colours to follow selected player not default player
Post by: prissi on January 31, 2014, 11:45:53 PM
They still do, when I just checked. The title bar in pak64 changes color.
Title: Re: GUI colours to follow selected player not default player
Post by: Ters on February 01, 2014, 07:28:38 AM
Quote from: prissi on January 31, 2014, 11:45:53 PM
They still do, when I just checked. The title bar in pak64 changes color.

Menu buttons do not, but I'm not sure if they really use the special player color, or just one that is very close. There is however a usability issue if these buttons follow the selected player color. The selected player color may lack contrast against other parts of the button image, making it "unreadable". Since player colors can only be selected from a limited palette, it is likely possible for artists to avoid this problem.
Title: Re: GUI colours to follow selected player not default player
Post by: jamespetts on February 01, 2014, 11:14:10 AM
I know that some of the sign graphics in the Pak128.Britain toolbars have this issue; but the player colour there is only used where the player colour would actually be used in the object represented by the button, so this is not in principle a problem, except where the player colour is not the colour of the currently selected player.
Title: Re: GUI colours to follow selected player not default player
Post by: Fabio on February 01, 2014, 01:49:24 PM
They seem to follow the "human" player (changing accordingly) but they don't change when you switch player, at least in pal 128


Sent from my iPhone using Tapatalk
Title: Re: GUI colours to follow selected player not default player
Post by: Ters on February 01, 2014, 03:52:59 PM
Quote from: Fabio on February 01, 2014, 01:49:24 PM
They seem to follow the "human" player (changing accordingly) but they don't change when you switch player, at least in pal 128


Sent from my iPhone using Tapatalk

That means that the matching colors issue is already something artists must deal with.


Sent from my home using photons.
Title: Re: GUI colours to follow selected player not default player
Post by: TurfIt on February 01, 2014, 07:10:12 PM
Should now work with r7053.
Title: Re: GUI colours to follow selected player not default player
Post by: jamespetts on February 02, 2014, 11:22:02 AM
Excellent!
Title: Re: GUI colours to follow selected player not default player
Post by: jamespetts on February 10, 2014, 12:48:35 AM
I have noticed that this is implemented for menu buttons but not cursor icons, which still retain player 0's colouring. Is there any chance that this could be applied to the icons, too?