The International Simutrans Forum

Simutrans Extended => Pak128.Britain-Ex Bug Reports => Pak128.Britain-Ex => Simutrans-Extended paksets => Pak128.Britain-Ex closed bug reports => Topic started by: Spenk009 on December 17, 2014, 12:47:15 PM

Title: [0.9.1] - 1950s station buildings graphics error - fix
Post by: Spenk009 on December 17, 2014, 12:47:15 PM
I noticed the winter images of the 1950s station buildings have problems with their winter images. This affects all but the naval version.

I filled the roofs in with a solid white and compiled the paks to double-check. Attached is a comparison of old vs new. The updates are moved in a pull request on github.

Other items there are: removing the underground limit on early end of choose signals, adding the axle load on a SR 4-6-2 upgrade, adding biological traction to the (modern) road depots to enable the postal boy and upping the speed limit of the Class 7P tender from 155 to 160. If some of these require discussion, I've listed them here for convenience.
Title: Re: [0.9.1] - 1950s station buildings graphics error - fix
Post by: jamespetts on December 20, 2014, 10:31:27 AM
Thank you very much for that. I have pulled and merged your branch, but I do not understand (and for the time being have reverted) the fix marked, "End of choose signal underground limitation". allow_underground=2 means that the asset is allowed both underground and overground; 0 means that it can be built only overground and 1 only underground. Why should the old end of choose signal be only overground? I know that some earlier era signals (pre 1860s) are overground only, but the end of choose is not an ordinary, working signal, but more of a marker.
Title: Re: [0.9.1] - 1950s station buildings graphics error - fix
Post by: Spenk009 on December 20, 2014, 10:46:45 AM
This has been fixed already after this post (http://forum.simutrans.com/index.php?topic=13319.0) a few months ago. I just found it hadn't changed in both 0.9.1 and the way-improvements branch.

The problem is with the attached signals. The "end of choose signal" can (in 0.9.1) only be placed underground.
Title: Re: [0.9.1] - 1950s station buildings graphics error - fix
Post by: jamespetts on December 20, 2014, 11:15:13 AM
Do not forget that the half-heights branch is very different to 0.9.1, as a lot of changes have been made since the last release.
Title: Re: [0.9.1] - 1950s station buildings graphics error - fix
Post by: Spenk009 on December 20, 2014, 11:51:41 AM
I hope I corrected the correct files then, it took me a while to figure out the branch management for GitHub.

How are we looking for a new release? Do you want to get more features done or will the next version come simultaneously with a new version of Experimental?
Title: Re: [0.9.1] - 1950s station buildings graphics error - fix
Post by: jamespetts on December 20, 2014, 11:59:43 AM
Quote from: Spenk009 on December 20, 2014, 11:51:41 AM
I hope I corrected the correct files then, it took me a while to figure out the branch management for GitHub.

How are we looking for a new release? Do you want to get more features done or will the next version come simultaneously with a new version of Experimental?

I expect that the next release of the pakset will come with the next major release of Experimental, but the latter may be some time off, since I want to focus on adding the various features necessary for good balance before releasing again, which might take some time (especially as I am still in the midst of a rather drawn-out house move).