The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: captain crunch on January 09, 2015, 02:39:31 PM

Title: destroying bridge: Assertion `ribi_t::ist_einfach(ribi)' failed
Post by: captain crunch on January 09, 2015, 02:39:31 PM
Removing the bridge crashes the program (svn-version trunk@7467, compiled with clang++ 3.5 on linux amd64 3.16 with libsdl 2.0.2)
To reproduce:
Title: Re: destroying bridge: Assertion `ribi_t::ist_einfach(ribi)' failed
Post by: Ters on January 09, 2015, 04:39:27 PM
I don't get any crashes, but bridge removal was very unusual for bridges, as I could remove it piece by piece.
Title: Re: destroying bridge: Assertion `ribi_t::ist_einfach(ribi)' failed
Post by: TurfIt on January 09, 2015, 05:24:41 PM
Bridge building (and destruction) is completely screwed up at the moment. Not sure if anyone is still working on this or not...
The bridge shown shouldn't be possible to build in the first place - always needs atleast one ramp. i.e. Can't build between two cliffs - need elevated ways for that.
Title: Re: destroying bridge: Assertion `ribi_t::ist_einfach(ribi)' failed
Post by: Markohs on January 09, 2015, 05:44:15 PM
Indeed, that bridge shoudn't have been able to build. I'm working on bridge building changes in the code, too, but what caused this to happen, the double height changes?
Title: Re: destroying bridge: Assertion `ribi_t::ist_einfach(ribi)' failed
Post by: Dwachs on January 09, 2015, 06:01:35 PM
Building such bridges was introduced with r7299, I guess. I was not following development at that time, too.
Title: Re: destroying bridge: Assertion `ribi_t::ist_einfach(ribi)' failed
Post by: DrSuperGood on January 09, 2015, 07:19:10 PM
Elevated ways incorrectly check ownership of buildings under them during placement where as placing a building under does not check ownership of the elevated way above.

Elevated ways assume all buildings with a second story tile image as unpassable. Towns on the other hand have no issue plonking a multi tile image building under elevated ways.

Bridges do not perform a height check on buildings. Although you should be able to bridge over every building you should need at least as much clearance as tiles high the building is to avoid weird graphics.
Title: Re: destroying bridge: Assertion `ribi_t::ist_einfach(ribi)' failed
Post by: prissi on January 10, 2015, 09:55:01 PM
Building such bridges was introduced as feature. I do not think it would harm, although the removal should work as before. There are probably even more error lurking there.