The International Simutrans Forum

Simutrans Extended => Simutrans-Extended bug reports => Simutrans-Extended development => Simutrans-Extended closed bug reports => Topic started by: Vladki on November 01, 2016, 07:10:22 PM

Title: Trains exit one train staff mode incorrectly
Post by: Vladki on November 01, 2016, 07:10:22 PM
Please see the game on restored server.exp.simutrans.com. Look for Trnava Grain mill, or Dairy

Trains switch from one-staff to track-circuit after (un)loading and reversing. They should stay in one-staff mode.
Title: Re: Trains exit one train staff mode incorrectly
Post by: jamespetts on November 01, 2016, 07:31:06 PM
Thank you for the report: I have split this from the other topic, since this appears to be a different issue.
Title: Re: Trains exit one train staff mode incorrectly
Post by: Vladki on November 27, 2016, 01:55:01 PM
Just a bump - the one-train staff mode is still acting weird. Trains turn to track-circuit on reversal, sometimes more than one enter the on-staff area, leave portions of track reserved. Just have a look at the server game, it will quickly get stuck near the staff cabinets at Nemcanka or Selpice station.
Title: Re: Trains exit one train staff mode incorrectly
Post by: jamespetts on December 01, 2016, 12:13:12 AM
I notice that the one train staff cabinets for trains travelling in different directions on the double track section are not immediately adjacent to one another, but several tiles (i.e., several hundred meters) away from one another. A set of one train staff cabinets will not work as one unless they are right next to each other. So, for example, the cabinet at 76,86 cannot work with the cabinet at 74,87: the matching cabinet would have to be at 76,87.

The reason for this is that they really should be a single cabinet (i.e., there is only one one train staff, and it is kept in just one cabinet), but it is too difficult to write code that would allow one track to use a cabinet placed on another track, so using a pair immediately next to each other is the next best thing.

Can you try relocating one of both sets of cabinets and see whether this resolves the issue?
Title: Re: Trains exit one train staff mode incorrectly
Post by: AP on December 05, 2016, 07:45:23 PM
Quote from: jamespetts on December 01, 2016, 12:13:12 AMA set of one train staff cabinets will not work as one unless they are right next to each other.
Does diagonal adjacency work, out of interest?
Title: Re: Trains exit one train staff mode incorrectly
Post by: jamespetts on December 05, 2016, 09:57:17 PM
I have to say, I cannot remember whether I tested that. I think that it should, however, as it checks all neighbouring tiles, if I recall correctly.
Title: Re: Trains exit one train staff mode incorrectly
Post by: Vladki on December 05, 2016, 10:06:55 PM
Quote from: jamespetts on December 01, 2016, 12:13:12 AM
Can you try relocating one of both sets of cabinets and see whether this resolves the issue?

I have put one-staff cabinets only at Selpice station (siding to the cow farm), but still it is not ok. Trains sometimes escape the area still in on-staff mode. Could you please rearrange the boxes yourself into arrangement that should work ?
Title: Re: Trains exit one train staff mode incorrectly
Post by: Vladki on January 08, 2017, 07:10:01 PM
James, may you have a look on the server.exp.simutrans.com, and check the one-train staff arrangement, if it is built correctly? If you still have connections problems, I can upload a fresh savegame for you
Title: Re: Trains exit one train staff mode incorrectly
Post by: jamespetts on January 08, 2017, 11:11:29 PM
Can you upload the fresh saved game? I should be most grateful.
Title: Re: Trains exit one train staff mode incorrectly
Post by: Vladki on January 08, 2017, 11:58:50 PM
here you are
http://server.exp.simutrans.com/debug-saves/server13353-network.sve
Title: Re: Trains exit one train staff mode incorrectly
Post by: Vladki on February 19, 2017, 12:23:13 AM
I think this bug has transformed to something else. When a train that is in the one-staff zone reverses, it clears the reservation, and another train can enter the one-staff zone - leading to a deadlock.
http://server.exp.simutrans.com/screenshots/simscr28.jpg and 29.jpg
Title: Re: Trains exit one train staff mode incorrectly
Post by: jamespetts on March 08, 2017, 11:36:06 PM
I think that I have fixed this; would you be able to re-test? I should be most grateful.
Title: Re: Trains exit one train staff mode incorrectly
Post by: Vladki on March 12, 2017, 10:02:50 PM
This seems to be fixed now.