The International Simutrans Forum

Simutrans Extended => Simutrans-Extended bug reports => Simutrans-Extended development => Simutrans-Extended closed bug reports => Topic started by: Vladki on April 27, 2017, 11:21:46 PM

Title: signal reassign tool crashes if the signal was not assigned previously
Post by: Vladki on April 27, 2017, 11:21:46 PM
I'm starting experiments with signalboxes. Up to now I had all signals in pak128.CS set so that they do not need a signalbox. Now I have a signalbox, and wanted to add them to an older savegame. But when I try to assign a signal to a signalbox, the game segfaults. I suspect that it tries to access a null pointer (or something similar), if the signal is not assigned to any signal box yet, and the tool tries to assign it.

I understand that this is not hight priority, as the signals work well even without signalbox, but it could happen to others who will try to fiddle with older savegames from pre-signalbox era.
Title: Re: signal reassign tool crashes if the signal was not assigned previously
Post by: jamespetts on April 29, 2017, 12:52:12 AM
This is difficult to reproduce without actually having your saved game and pakset - are you able to upload one of each? Crash bugs are generally easier to fix and a higher priority than other sorts of bugs.
Title: Re: signal reassign tool crashes if the signal was not assigned previously
Post by: Vladki on April 30, 2017, 10:11:12 AM
Save: http://server.exp.simutrans.com/debug-saves/trnava.sve
Pakset: http://server.exp.simutrans.com/pak128.CS-Ex.zip

You can see that all stations have signalboxes, but only Bukova has the signals connected to signalbox (I have deleted them and build new).
In previous versions of the pakset, I had no signalboxes, and signals had not specified signal_groups, so could be build without signalbox.
Now AZD70 signals must be connected to signalbox, except for automatic block permissive signals (white pole). You can try to attach any signal with red-white striped pole to a signalbox and the game instantly crashes. The signal reassign tool is in the special tools box at the right end with empty icon.
Title: Re: signal reassign tool crashes if the signal was not assigned previously
Post by: jamespetts on April 30, 2017, 11:46:42 AM
I think that I have fixed this; would you be able to confirm?
Title: Re: signal reassign tool crashes if the signal was not assigned previously
Post by: Vladki on April 30, 2017, 11:53:50 AM
Fixed, thank you