The International Simutrans Forum

Simutrans Extended => Simutrans-Extended bug reports => Simutrans-Extended development => Simutrans-Extended closed bug reports => Topic started by: Ves on December 13, 2017, 10:51:34 PM

Title: Bug - Convoy resets classes in some circumstances
Post by: Ves on December 13, 2017, 10:51:34 PM
I have noticed on the servers that my ships change classes back to their defaults by them self occasionally. It has bugged me alot, also since I could not find a point where they did so.
I now have discovered one occassion where they do that, namely when the game is saving.
Here are the steps to follow in order to trace the bug:

* Open this savegame: https://github.com/VictorErik/saved-games/raw/master/master/Bug%20-%20Automatically%20reset%20classes.sve (https://github.com/VictorErik/saved-games/raw/master/master/Bug%20-%20Automatically%20reset%20classes.sve)
* Open the depot window in view and then the class manager of the convoy in view
* Reassign the class to "high"
* Close the window. Verify by opening the window again that the class is still "high"
* Now save the game
* After the save cyclus is over and the game is continuing, open the depot and the class manager again, and the class is reassigned back to default
Title: Re: Bug - Convoy resets classes in some circumstances
Post by: jamespetts on December 15, 2017, 12:38:41 PM
Thank you for your report. I think that I have managed to fix this, which fix should be available in to-morrow's nightly build. I should be grateful if you could confirm whether this fix has been effectual.
Title: Re: Bug - Convoy resets classes in some circumstances
Post by: Ves on December 15, 2017, 01:59:25 PM
Appears to be fixed! Thanks!
Title: Re: Bug - Convoy resets classes in some circumstances
Post by: jamespetts on December 15, 2017, 02:08:49 PM
I have now pushed an improved fix for this, which does not (as the original fix did) remove a fix for a previous issue - would you be able to re-test? I should be most grateful.
Title: Re: Bug - Convoy resets classes in some circumstances
Post by: Ves on December 15, 2017, 02:59:15 PM
It appears to still be fixed!