The International Simutrans Forum

Simutrans Extended => Simutrans-Extended bug reports => Simutrans-Extended development => Simutrans-Extended closed bug reports => Topic started by: RESTRICTED ACCOUNT on May 03, 2018, 10:37:31 AM

Title: "Commuters demanded" is incorrect.
Post by: RESTRICTED ACCOUNT on May 03, 2018, 10:37:31 AM
I thought it strange that most of "Commuters demanded" evenly by 20% like these.
(https://simutrans-germany.com/files/upload/weird_commuter_demand_values.png)

I check these dat file, but different values are set for each.
So, I guess the following two possibilities.
1) the setting value is not displayed properly in the game.
2) makeobj does not correctly write these values.

In the example of town hall (https://github.com/jamespetts/simutrans-pak128.britain/blob/master/townhall/townhalls.dat), The total value of class_proportion is not 100 but 95 in its dat file.
However, the total value of "Wealth of visitors" is 100% in the game.
Although this has no problem, in the case of "class_proportion_jobs and Commuters demanded", the behavior of this function is strange.

In the example of ParishChurchHolyTrinity (https://github.com/jamespetts/simutrans-pak128.britain/blob/master/attractions/stone-attractions.dat),
Commuter demand of Very low is 0% as class_proportion_jobs[0]=0 is set, but other values are evenly by 25%. This seems to be different from the value written in dat file.

class_proportion_jobs[0]=0
class_proportion_jobs[1]=20
class_proportion_jobs[2]=30
class_proportion_jobs[3]=50
class_proportion_jobs[4]=0

(´・ω・`)
Title: Re: "Commuters demanded" is incorrect.
Post by: jamespetts on May 04, 2018, 12:06:17 AM
Thank you for your report. I think that I have now fixed this - I should be grateful if you could let me know whether this is fixed in the next nightly build.

(For information, the error was a GUI error and did not affect the underlying simulation logic).
Title: Re: "Commuters demanded" is incorrect.
Post by: RESTRICTED ACCOUNT on May 04, 2018, 09:06:37 AM
I confirmed that this issue has been fixed.
Thank you for such quickly fixing and letting me know the details.
Title: Re: "Commuters demanded" is incorrect.
Post by: Matthew on May 06, 2018, 01:02:20 AM
Thank you for fixing this. It helps to explain why my services were doing so poorly at attracting high-end passengers: they didn't exist!  :P Nice to see another bug bite the dust.