The International Simutrans Forum

Simutrans Extended => Simutrans-Extended bug reports => Simutrans-Extended development => Simutrans-Extended closed bug reports => Topic started by: wlindley on December 25, 2018, 05:30:01 PM

Title: "Revenue" in en.tab (from "Gewinn") should be "Profit"
Post by: wlindley on December 25, 2018, 05:30:01 PM
In en.tab line 2180 "Revenue" should be "Profit" ... otherwise in the Line Management dialogue, the top total and each individual convoy can have negative "Revenue" -- clearly impossible.

In gui/schedule_list.cc, the variable (see line 657) indeed is called "profit" so the translation is simply incorrect.
I would open a pull request but -- what is the correct protocol? Surely not creating a new branch for each of these minor changes, and we don't have write access to Master branch do we?
Title: Re: "Revenue" in en.tab (from "Gewinn") should be "Profit"
Post by: jamespetts on December 25, 2018, 05:54:53 PM
Splendid, thank you for spotting that: now fixed.

As to branches - you do not need to create a new branch for each fix, as you can simply push to the master branch on your own repository, which I can then merge.