The International Simutrans Forum

Simutrans Extended => Simutrans-Extended bug reports => Simutrans-Extended development => Simutrans-Extended closed bug reports => Topic started by: RESTRICTED ACCOUNT on December 31, 2018, 12:58:01 AM

Title: Bug: Month record of "transported goods" is incorrect
Post by: RESTRICTED ACCOUNT on December 31, 2018, 12:58:01 AM
I think the "Goods needed" chart in the City list dialog is broken.
(I posted here (https://forum.simutrans.com/index.php/topic,18669.msg177151.html#msg177151) but, the identity of "Good needed" seems to be transported goods in this chart.)

I noticed that there is no correlation between "Years" and "Months" in this chart.

(https://i.imgur.com/3PvVZlG.png)
The above image is in demo.sve. Probably since it used to function properly in the past, records of "months" remain.

However, when I fast forwarded with the current version extended, it continue to show 0.
(https://i.imgur.com/rJKmn8V.png)

Contrary to this, the value of "Years" will increase.
Title: Re: Bug: Month record of "transported goods" is incorrect
Post by: jamespetts on January 01, 2019, 11:45:53 AM
Thank you for the report. I think that I am going to have to wait until I get back home and can easily use a graphical debugger before looking into this one.
Title: Re: Bug: Month record of "transported goods" is incorrect
Post by: RESTRICTED ACCOUNT on January 28, 2019, 02:56:44 PM
I think I fixed this bug.
I threw a pull request (https://github.com/jamespetts/simutrans-extended/pull/103), so please check it.
(Again note that this data is "Goods transported", not "Goods needed")
Title: Re: Bug: Month record of "transported goods" is incorrect
Post by: jamespetts on January 28, 2019, 10:02:42 PM
Thank you very much for this: now incorporated.

My apologies for not having had a great deal of time to spend on Simutrans of late.
Title: Re: Bug: Month record of "transported goods" is incorrect
Post by: RESTRICTED ACCOUNT on February 04, 2019, 03:22:44 PM
Sorry for the late report but I confirmed that this bug has been fixed in #e24449c.