The International Simutrans Forum

Simutrans Extended => Simutrans-Extended bug reports => Simutrans-Extended development => Simutrans-Extended closed bug reports => Topic started by: RESTRICTED ACCOUNT on April 19, 2019, 09:07:21 AM

Title: [Bug fix] Station mail records are not written in the save data
Post by: RESTRICTED ACCOUNT on April 19, 2019, 09:07:21 AM
I noticed that every time I reloaded the saved game then the station's mail record was lost.  ???
This is due to an error in my code when Ranran implemented this. (´・ω・`)

I made a patch for fix this.
https://github.com/Ranran-the-JuicyPork/simutrans-extended/commits/bug-fix-of-station-mail-record

I apologize for the inconvenience, but please check this.
Title: Re: [Bug fix] Station mail records are not written in the save data
Post by: jamespetts on April 22, 2019, 10:09:43 PM
Thank you - now incorporated.
Title: Re: [Bug fix] Station mail records are not written in the save data
Post by: RESTRICTED ACCOUNT on April 23, 2019, 09:56:35 AM
I'm very sorry, the patch seems to have caused problems loading the old save.
It is not possible to load the save generated by the build after 2019/02/05. (You can load the today's build saved game.)


if ((file->get_extended_version() == 14 && file->get_extended_revision() > 5) || file->get_extended_version() > 15)

If you edit line 3973 of simhalt.cc like this, it will be able to load the saved game of 2019/02/05 - 2019/04/06's build.
However, I have no idea why it can not read the saved game after 04/07's build (ie get_extended_revision () == 8, with modified path_exploler).
Title: Crash on latest nightly while loading saved game
Post by: Jando on April 23, 2019, 11:59:23 AM
I'm seeing the latest nightly crash on loading any of my saved games. This is the Linux 64-bit version. Game either crashes directly to desktop or shows the following error message:

(http://i.imgur.com/P4xVyo5m.jpg) (https://imgur.com/P4xVyo5)

Bug or user error? :)
Title: Re: [Bug fix] Station mail records are not written in the save data
Post by: jamespetts on April 23, 2019, 12:04:55 PM
These two issues appear to be the same - I am looking into this now.
Title: Re: [Bug fix] Station mail records are not written in the save data
Post by: jamespetts on April 23, 2019, 12:31:05 PM
I think that I have now fixed this. I am about to run a manual recompile of the nightly build with this fix integrated.
Title: Re: [Bug fix] Station mail records are not written in the save data
Post by: RESTRICTED ACCOUNT on April 23, 2019, 01:14:47 PM
All saved game from February to April can now be loaded.  :D
Thank you very much!
Title: Re: [Bug fix] Station mail records are not written in the save data
Post by: Jando on April 23, 2019, 02:00:09 PM
Confirming issue fixed for me as well, thank your for the fast response!