The International Simutrans Forum

Simutrans Extended => Pak128.Britain-Ex Bug Reports => Pak128.Britain-Ex => Simutrans-Extended paksets => Pak128.Britain-Ex closed bug reports => Topic started by: RESTRICTED ACCOUNT on February 14, 2020, 12:49:45 PM

Title: BUG: Upgrade to a different vehicle than the selected vehicle
Post by: RESTRICTED ACCOUNT on February 14, 2020, 12:49:45 PM
Reproduction steps:
1) Purchase SR 2-NOL EMU
2) Upgrade the front vehicle to BR415 / 6
3) Attempt to upgrade the second vehicle to BR Class415 "4-EPB" EMU (rear) or BR Class416 "2-EPB" EMU (rear)

In both cases, it will be upgraded to a different vehicle than you chose.
(https://i.imgur.com/IV5pvXG.gif)
Unfortunately, there are now two vehicles facing forward...
(´・ω・`)お金返して?
Title: PR#499 - FIX: upgrade to the unselected vehicle in some case
Post by: RESTRICTED ACCOUNT on February 15, 2022, 03:37:29 PM
I think I have fixed this bug. Please check the pull request #499.

This was a very annoying bug because upgrades cannot be redone.

The bug is somehow caused by the simtool sending an order to the depot to upgrade to a vehicle that is not selected, but I could not figure out why. However, a check to make sure it's not wrong will stop it from trying to upgrade to the wrong vehicle.
Title: Re: BUG: Upgrade to a different vehicle than the selected vehicle
Post by: jamespetts on February 17, 2022, 11:24:36 PM
Excellent, thank you: now incorporated.