The International Simutrans Forum

Simutrans Extended => Pak128.Britain-Ex Bug Reports => Pak128.Britain-Ex => Simutrans-Extended paksets => Pak128.Britain-Ex closed bug reports => Topic started by: CK on February 18, 2020, 01:21:54 PM

Title: LSWR eight compartment carriages (1896) can't be converted to front DM
Post by: CK on February 18, 2020, 01:21:54 PM
The LSWR six and eight compartment carriages from October 1896 can't be converted into front driving motor carriages for the LSWR suburban EMU, but they can be converted into rear driving motor and trailer carriages. It does seem to be working normally for LBSCR carriages.

(https://i.imgur.com/fKWCleQ.png)
Title: Re: LSWR eight compartment carriages (1896) can't be converted to front DM
Post by: Spenk009 on February 18, 2020, 02:51:50 PM
Fixed, pull request here (https://github.com/jamespetts/simutrans-pak128.britain/pull/83)

Cause was that upgrades were doubly allowing the rear EMU vehicle rather than each front and rear.
Title: Re: LSWR eight compartment carriages (1896) can't be converted to front DM
Post by: Matthew on February 18, 2020, 03:17:17 PM
Quote from: Spenk009 on February 18, 2020, 02:51:50 PM
Fixed, pull request here (https://github.com/jamespetts/simutrans-pak128.britain/pull/83)

Cause was that upgrades were doubly allowing the rear EMU vehicle rather than each front and rear.

Thank you for fixing the problem so quickly. 90 minutes is a pretty impressive response time for any project!
Title: Re: LSWR eight compartment carriages (1896) can't be converted to front DM
Post by: Spenk009 on February 18, 2020, 04:09:40 PM
Thank you. It was a case of lucky timing in between lectures.
Title: Re: LSWR eight compartment carriages (1896) can't be converted to front DM
Post by: jamespetts on February 19, 2020, 01:59:21 AM
Thank you for the fix for this - now incorporated.
Title: Re: LSWR eight compartment carriages (1896) can't be converted to front DM
Post by: CK on February 25, 2020, 04:25:59 PM
The same mistake appears to have been made with the 3Sub upgrades (https://i.imgur.com/z5Y4Mng.png)
Title: Re: LSWR eight compartment carriages (1896) can't be converted to front DM
Post by: Spenk009 on March 07, 2020, 06:35:11 PM
My apologies for leaving this so long. I've looked at the issue and a fix (with Pull Request) can be found here (https://github.com/jamespetts/simutrans-pak128.britain/pull/84).

I have noticed that there are many vehicles that allow an upgrade to SR 3-SUB for the front and rear vehicles, but don't allow this for the trailer (centre) vehicles. This is the case for SR-4* vehicles and some LSWR ones, for example. Would it make sense to allow a conversion of the first trailer vehicle or even extending the availability of the centre vehicle for players wishing to make late conversions?