The International Simutrans Forum

Simutrans Extended => Simutrans-Extended development => Simutrans-Extended bug reports => Topic started by: freddyhayward on August 09, 2020, 02:27:50 AM

Title: [FIX] Common desyncs on server reloading
Post by: freddyhayward on August 09, 2020, 02:27:50 AM
I've made a pull request that, in my testing, fixes the notorious desync issues caused whenever force-syncs occur while editing schedules, names, etc. The problem was solved by simply reordering a few lines of code in the load function. View here:
https://github.com/jamespetts/simutrans-extended/pull/238
Title: Re: [FIX] Common desyncs on server reloading
Post by: jamespetts on August 09, 2020, 11:34:58 AM
Splendid, thank you for that: now incorporated.
Title: Re: [FIX] Common desyncs on server reloading
Post by: freddyhayward on August 09, 2020, 11:53:03 AM
Thanks - I had made a TODO comment in one of my commits about the use of pre-increment (++i) when clearing the checklist history. Can you recall or guess why this was used?
Title: Re: [FIX] Common desyncs on server reloading
Post by: jamespetts on August 09, 2020, 12:21:27 PM
Quote from: freddyhayward on August 09, 2020, 11:53:03 AM
Thanks - I had made a TODO comment in one of my commits about the use of pre-increment (++i) when clearing the checklist history. Can you recall or guess why this was used?

It was not me who wrote this code; I believe that this code was written by Bernd Gabriel many years ago, and I do not know how it works.