Text only | Text with Images

The International Simutrans Forum

Simutrans Extended => Simutrans-Extended bug reports => Simutrans-Extended development => Simutrans-Extended closed bug reports => Topic started by: freddyhayward on December 24, 2020, 12:27:52 AM

Title: Players can sell/withdraw/retire other players' convoys thru detail dialog
Post by: freddyhayward on December 24, 2020, 12:27:52 AM
per title - should be reproducible in all circumstances.
Title: Re: Players can sell/withdraw/retire other players' convoys thru detail dialog
Post by: RESTRICTED ACCOUNT on December 24, 2020, 01:49:05 AM
I believe I have fixed it. Pull request #321.
It also contains a fix for another bug in halt detail.
Title: Re: Players can sell/withdraw/retire other players' convoys thru detail dialog
Post by: freddyhayward on December 24, 2020, 01:54:55 AM
Quote from: Ranran on December 24, 2020, 01:49:05 AM
I believe I have fixed it. Pull request #321.
It also contains a fix for another bug in halt detail.
Thank you. Looking at the convoy info window reminded me of something. The 'times history' button should be enabled for all players because it does not modify the convoy.
Title: Re: Players can sell/withdraw/retire other players' convoys thru detail dialog
Post by: RESTRICTED ACCOUNT on December 24, 2020, 02:53:25 AM
Quote from: freddyhayward on December 24, 2020, 01:54:55 AMThe 'times history' button should be enabled for all players because it does not modify the convoy.
I think it was such a specification from the time of implementation.
I was trying to make it one of the tabs, but I'm struggling with it.
Title: Re: Players can sell/withdraw/retire other players' convoys thru detail dialog
Post by: jamespetts on December 24, 2020, 10:48:48 AM
Thank you very much for the fix: now incorporated.
Text only | Text with Images