The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: RESTRICTED ACCOUNT on March 01, 2021, 02:39:32 PM

Title: The color of the top border of the banner is fixed
Post by: RESTRICTED ACCOUNT on March 01, 2021, 02:39:32 PM
The color of the top border of the banner is fixed in light gray(RGB=222,218,222).

This part is this color(RGB=222,218,222) in all themes. This is incorrect for all themes, but it's not very noticeable at the moment.
However, it becomes noticeable with the following theme settings.

(https://i.imgur.com/47MWVJe.png)

I suspect it may be because this window doesn't have a title bar.
Title: Re: The color of the top border of the banner is fixed
Post by: RESTRICTED ACCOUNT on March 01, 2021, 03:29:10 PM
// add white line on top since this frame has no title bar.
display_fillbox_wh_clip_rgb(pos.x, pos.y, size.w, 1, color_idx_to_rgb(COL_GREY6), false);

This behavior seems to be intended. But I don't think this behavior is correct.
Title: Re: The color of the top border of the banner is fixed
Post by: Dwachs on March 05, 2021, 06:39:55 PM
should be fixed in r9673
Title: [r9673] The color of the top border of the banner is still fixed
Post by: RESTRICTED ACCOUNT on November 05, 2021, 04:37:57 AM
Quoteshould be fixed in r9673
I find that this bug was still unresolved. (´・ω・`)
I think you made something that should be displayed, but I don't think the display will change because you haven't removed the COL_GREY6 upper frame that was used as a countermeasure before the fix.
Need to remove the lines already mentioned.
Title: Re: The color of the top border of the banner is fixed
Post by: Dwachs on November 05, 2021, 09:32:51 AM
Which theme setting controls that green color? Just to be sure. Years back I received quite a beating because of the (then missing) line.
Title: Re: The color of the top border of the banner is fixed
Post by: RESTRICTED ACCOUNT on November 05, 2021, 09:41:06 AM
Quote from: Dwachs on November 05, 2021, 09:32:51 AMWhich theme setting controls that green color? Just to be sure. Years back I received quite a beating because of the (then missing) line.
I don't remember the details, but I think the frames are all images included in the pak.
Please test it by using the attached theme.
Title: Re: The color of the top border of the banner is fixed
Post by: Dwachs on November 05, 2021, 10:45:04 AM
Put this line to rest with r10215