All sorts of desyncs are now occurring immediately since the recent merger. They can be reliably reproduced by joining a headless server game with a graphical client. The desync will differ depending on the save, but it almost always happens on developed maps.
edit: this has been fixed by https://github.com/jamespetts/simutrans-extended/pull/406. The problem was that pakset settings were not loaded by headless servers. This was extremely tricky to find, so I recommend that all future large pull requests are tested using headless servers and graphical clients. Could this pleased be moved to the pull requests section?
Thank you for this - now incorporated. I have not had a chance to look at these issues in detail this week as I have been very busy at work.
Quote from: freddyhayward on July 01, 2021, 06:20:08 AM
This was extremely tricky to find
That indeed looks a nightmare to find, a single missing line loading an environment variable. Thank you for putting in the time to find and fix this. And thank you James for integrating it.
Thank you for finding that one needed line.
Indeed even though the surrounding code is pretty much the same as standard, that line that doesn't exist in standard is just a nightmare. I don't want to suffer from such nightmares anymore, so I won't do this after r9919. (´・ω・｀)
I added the same line in standard, as it will not do any harm to have it there. So no future worries about merging.
Quote from: prissi on July 02, 2021, 01:27:00 PM
I added the same line in standard, as it will not do any harm to have it there. So no future worries about merging.
Which line do you mean? I can't see anything added on github.
The mirror is only updated every 6 hours, so the commit will only be visible on github in about an hour from now.