The International Simutrans Forum

Simutrans Extended => Simutrans-Extended bug reports => Simutrans-Extended development => Simutrans-Extended closed bug reports => Topic started by: Phystam on August 12, 2021, 07:15:01 AM

Title: All servers are down
Post by: Phystam on August 12, 2021, 07:15:01 AM
Today's nightly update causes segmentation faults in all servers... However, the graphical client can successfully load the save data.
Title: Re: All servers are down
Post by: jamespetts on August 12, 2021, 06:44:02 PM
Thank you for the report. Looking into this now. The first indication that I have is the following backtrace:


Program received signal SIGSEGV, Segmentation fault.
0x000055555568f7d5 in ground_desc_t::register_desc(ground_desc_t const*) ()
(gdb) backtrace
#0  0x000055555568f7d5 in ground_desc_t::register_desc(ground_desc_t const*) ()
#1  0x00005555556998a0 in obj_reader_t::read_nodes(_IO_FILE*, obj_desc_t*&, int, unsigned int) ()
#2  0x0000555555699884 in obj_reader_t::read_nodes(_IO_FILE*, obj_desc_t*&, int, unsigned int) ()
#3  0x00005555556999a8 in obj_reader_t::read_file(char const*) ()
#4  0x000055555569a15f in obj_reader_t::load(char const*, char const*) ()
#5  0x0000555555a1cd62 in simu_main(int, char**) ()
#6  0x0000555555aa12b9 in sysmain(int, char**) ()
#7  0x00007ffff79900b3 in __libc_start_main (main=0x55555565a600 <main>, argc=25, argv=0x7fffffffe208, init=<optimized out>,
    fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffe1f8) at ../csu/libc-start.c:308
#8  0x000055555565a66e in _start ()

Edit: Preliminary tests suggest that reverting commit bb2e73bb935f5eaeb89b97b654503c023de38715 may fix the issue. Running a recompile on the server now to test this.
Title: Re: All servers are down
Post by: jamespetts on August 12, 2021, 07:47:05 PM
Now back up and running again - the above reversion indeed succeeded.
Title: Re: All servers are down
Post by: RESTRICTED ACCOUNT on August 12, 2021, 10:57:58 PM
Thank you for fixing it. The peripheral code for that commit looked similar to standard, but it could have been missing elsewhere. I didn't notice the problem as I was able to load the offline game without problems even after merging it.
Title: Re: All servers are down
Post by: TurfIt on August 13, 2021, 01:14:03 AM
The fix for the reverted code is Standard r9707.
Title: Re: All servers are down
Post by: Phystam on August 13, 2021, 02:28:37 AM
This bug seems to be fixed. Thank you all!