The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: Yona-TYT on October 18, 2021, 06:25:35 PM

Title: [GUI] Cancel button in the install pakset window
Post by: Yona-TYT on October 18, 2021, 06:25:35 PM
 When we mistakenly enter the install pakset window, there is no way to go back, so for practical use we need a "Cancel" button to return us to the select pakset window.
(https://github.com/Yona-TYT/imgs/raw/main/244208954_4307783065965478_94496451297784393_n.jpg)
Title: Re: [GUI] Cancel button in the install pakset window
Post by: prissi on October 19, 2021, 01:33:54 AM
There is a cancel button in r10179
Title: Re: [GUI] Cancel button in the install pakset window
Post by: Yona-TYT on October 22, 2021, 04:10:15 PM
Simutrans stops working when you use the new "cancel" button for the second time.
Title: Re: [GUI] Cancel button in the install pakset window
Post by: prissi on October 23, 2021, 11:49:21 AM
That is intended. There is no need to see this so many times, just one install and then start with that. But it can be easily changed.
Title: Re: [GUI] Cancel button in the install pakset window
Post by: Yona-TYT on February 19, 2022, 10:20:10 PM
I apologize for reviving this topic, (seemed appropriate to do so).  :-[ 
The cancel button doesn't work, but this time it's during the loaded game (not in the select paksets window).
Title: Re: [GUI] Cancel button in the install pakset window
Post by: prissi on February 20, 2022, 12:01:34 PM
Sorry, do you mean it does not work when called from the option window?
Title: Re: [GUI] Cancel button in the install pakset window
Post by: Yona-TYT on February 20, 2022, 12:05:23 PM

Quote from: prissi on February 20, 2022, 12:01:34 PM
Sorry, do you mean it does not work when called from the option window?
exactly, at least that happens here in Linux fedora.
Title: Re: [GUI] Cancel button in the install pakset window
Post by: prissi on February 20, 2022, 01:48:59 PM
You should not see this under Linux. Hmm.
Title: Re: [GUI] Cancel button in the install pakset window
Post by: Roboron on February 20, 2022, 02:46:00 PM
Since r10485 it shows itself in an additional windows instead of its own screen https://github.com/aburch/simutrans/commit/2f5ddbe57716ab56b84de7c272bcb6d44171cbfa#diff-110c80a8fa76ec8f5023c7ca4a5cef0ec9b202330cd0893f753896c7afc20b90

But then the cancel button was not updated to call destroy_win when pressed.

But after prissi's last comment, I am not sure what its intention was/is.
Title: Re: [GUI] Cancel button in the install pakset window
Post by: prissi on February 21, 2022, 07:08:11 AM
Indeed, the destroy windows call was missing. Should work again in r10499
Title: Re: [GUI] Cancel button in the install pakset window
Post by: Yona-TYT on March 13, 2022, 09:32:04 AM
Quote from: prissi on February 21, 2022, 07:08:11 AM
Indeed, the destroy windows call was missing. Should work again in r10499
The "Cancel" button still doesn't work.  :-[
(https://github.com/Yona-TYT/imgs/raw/main/Captura%20de%20pantalla%20de%202022-03-13%2005-21-06.png)
Title: Re: [GUI] Cancel button in the install pakset window
Post by: prissi on March 13, 2022, 11:32:39 AM
In this case the cancel button is rather useless, since the window can be closed manually anyway. Also the install path was not used. Should work more like intended in r10554