The International Simutrans Forum

Simutrans Extended => Simutrans-Extended bug reports => Simutrans-Extended development => Simutrans-Extended closed bug reports => Topic started by: Phystam on February 24, 2022, 10:12:22 AM

Title: Cannot edit climate information after selecting a new map image
Post by: Phystam on February 24, 2022, 10:12:22 AM
I created a new map and tried to change the climate, but it resets to a random map and I can't change it. After selecting a bitmap image, make sure that the small window shows the selected image. Then select Climate Settings to reset it back to a random map.
I think this is a behavior that was changed in a recent update.
See this video:
> https://cdn.discordapp.com/attachments/737992275220627456/946346197885517864/climate.mp4 (https://cdn.discordapp.com/attachments/737992275220627456/946346197885517864/climate.mp4)
Title: Re: Cannot edit climate information after selecting a new map image
Post by: jamespetts on February 24, 2022, 07:34:42 PM
Thank you for the report. This does not on the face of it seem to relate to a part of Simutrans that differs as between Standard and Extended - does anyone know whether this can be reproduced in Standard?
Title: Re: Cannot edit climate information after selecting a new map image
Post by: RESTRICTED ACCOUNT on February 24, 2022, 10:43:32 PM
This cannot be reproduced with standard. This seems to be due to the changes made between June 30th and July 15th last year.
However, of the changes that have occurred in the meantime, the modifications made to welt.cc and climates.cc are minor and do not appear to have a direct impact.
The problem seems to be that some external influence has created a condition that resets the loaded_heightfield flag.
For example, the link to the loaded map image file is incorrect.
Title: PR#516 - FIX: Cannot edit climate information after selecting a new map image
Post by: RESTRICTED ACCOUNT on February 26, 2022, 12:36:38 PM
I think I have fixed this bug. Check the pull request #516.

Oddly enough, this bug seemed to be caused by the order in which the random map buttons and minimap were placed.
Quote from: Ranran on February 24, 2022, 10:43:32 PMThis seems to be due to the changes made between June 30th and July 15th last year.
However, the placement hasn't changed near the commit where the bug occurred, and I wonder if external factors affected it.

Anyway, the placement has been changed and adjusted.
Title: Re: Cannot edit climate information after selecting a new map image
Post by: Phystam on April 08, 2022, 11:35:42 AM
This fix is an urgent issue for new players who want to start with a bitmap terrain (like me:) ).
I think this fix seems now well working and is ready to merge.