The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: Yona-TYT on March 04, 2022, 01:34:08 PM

Title: [Minimap] Networks should have a separate section
Post by: Yona-TYT on March 04, 2022, 01:34:08 PM

The networks on the minimap leave very limited space due to the colored buttons.

In general, if I'm going to review networks  (spider web as seen in an online game), I don't need to be looking at the colored buttons since they take up a lot of space.

What do you think, place a button to only show the network switch and its filters?.

(https://github.com/Yona-TYT/imgs/raw/main/Captura%20de%20pantalla%20de%202022-03-04%2009-21-11.png)
Title: Re: [Minimap] Networks should have a separate section
Post by: Mariculous on March 05, 2022, 10:13:44 AM
This time, you might consider a Frankentrans backport from extended

Title: Re: [Minimap] Networks should have a separate section
Post by: prissi on March 05, 2022, 11:28:28 AM
How do you deal with option selected that affect the net display when hiding?
Title: Re: [Minimap] Networks should have a separate section
Post by: RESTRICTED ACCOUNT on March 05, 2022, 11:50:38 AM
As I mentioned in the related thread of extended, the only useful color buttons in network mode are the red buttons, and at the point the green buttons are a bit worth it. Other than that, it is worthless in network display mode. Therefore, it is kinder to the player if meaningless options are hidden.
I then tried to separate the open/close options by color but gave up after suffering from an unexplained crash on linux... Maybe I broke a strict code rule in linux.
Title: Re: [Minimap] Networks should have a separate section
Post by: Mariculous on March 05, 2022, 11:57:44 AM
Quote from: prissi on March 05, 2022, 11:28:28 AM
How do you deal with option selected that affect the net display when hiding?
These are applied. The settings are just hidden, not nonexistent.
Title: Re: [Minimap] Networks should have a separate section
Post by: Yona-TYT on March 05, 2022, 05:20:18 PM
I think the colored buttons take up a lot of space on the minimap, and it's not something I play with very often (activate factories, depot and city limits), after that I don't use them anymore. From there, I only activate and deactivate the networks without the need to look at those colorful buttons.

Although maybe it's just my particular way of seeing this.  :P
Title: Re: [Minimap] Networks should have a separate section
Post by: Roboron on March 18, 2022, 09:16:26 PM
r10557 backports Ranran's division of "Selections" button into "Selections" and "Show networks" from Extended  :)
Title: Re: [Minimap] Networks should have a separate section
Post by: Yona-TYT on March 19, 2022, 01:28:25 AM
Quote from: Roboron on March 18, 2022, 09:16:26 PMr10557 backports Ranran's division of "Selections" button into "Selections" and "Show networks" from Extended  :)
Thank you very much friend!.  8)

There is a small bug with the mouse wheel event, it doesn't respond to the scroll bar.
(https://github.com/Yona-TYT/imgs/raw/main/Captura%20de%20pantalla%20de%202022-03-18%2021-23-27.png)
Title: Re: [Minimap] Networks should have a separate section
Post by: Roboron on March 19, 2022, 07:43:26 AM
I can not reproduce. The wheel is working for me.
Title: Re: [Minimap] Networks should have a separate section
Post by: Yona-TYT on March 19, 2022, 12:06:00 PM
Quote from: Roboron on March 19, 2022, 07:43:26 AM I can not reproduce. The wheel is working for me.

What happens is that the filter is displayed over the mini-map area and it calls the zoom event which doesn't let the scroll bar work.
Title: Re: [Minimap] Networks should have a separate section
Post by: Roboron on March 19, 2022, 01:49:59 PM
Ah, yes. If the mouse is over the minimap _and_ the list, the minimap seems to take preference capturing the mouse wheel over the list. This bug is also present in Extended. But I don't have idea how to fix.
Title: Re: [Minimap] Networks should have a separate section
Post by: Roboron on March 20, 2022, 11:24:43 AM
Ok, I fixed it in r10564, hopefully with unintended consequences  :-X
Title: Re: [Minimap] Networks should have a separate section
Post by: Yona-TYT on March 20, 2022, 11:28:22 AM
Quote from: Roboron on March 20, 2022, 11:24:43 AMOk, I fixed it in r10564, hopefully with unintended consequences  :-X



(https://memegenerator.net/img/instances/63288471/ya-lo-veremos-eso-ya-lo-veremos.jpg)
Title: Re: [Minimap] Networks should have a separate section
Post by: prissi on March 20, 2022, 01:15:16 PM
Thanks, but the logic behind had become really hacky over the years, especially since there was already a class for the minimap scrollpane ... see r10566, and also added to base.tab (with a slightly changed translation also in SImutranslator).
Title: Re: [Minimap] Networks should have a separate section
Post by: Yona-TYT on March 20, 2022, 10:18:40 PM
Thank you very much for implementing that!...  It helps a lot to have those independent filters on small screens.  :D