The International Simutrans Forum

Simutrans Extended => Simutrans-Extended development => Simutrans-Extended bug reports => Topic started by: Rollmaterial on July 08, 2021, 10:24:58 PM

Title: Bridge deletion corruption issues
Post by: Rollmaterial on July 08, 2021, 10:24:58 PM
Does this cause corruption when removing tunnels? Asking to avoid potential duplicate bug reports.

Mod note: This has been split from this (https://forum.simutrans.com/index.php/topic,20994.0.html) unrelated topic
Title: Re: Data race in objlist_t::remove when running headless server
Post by: Matthew on July 09, 2021, 01:02:27 PM
Quote from: Rollmaterial on July 08, 2021, 10:24:58 PM
Does this cause corruption when removing tunnels? Asking to avoid potential duplicate bug reports.

I seems unlikely, though this kind of thing is way out of my depth.

I tried building tunnels in the latest client's single-player mode and nothing strange happened, though that does not test for out-of-sync errors in network games.
Title: Re: Re: Data race in objlist_t::remove when running headless server
Post by: Rollmaterial on July 09, 2021, 02:52:26 PM
What I'm describing doesn't seem to occur when removing the entire tunnel by using the general remove tool on a portal. It only occurs with the way removal tool.
Title: Re: Re: Data race in objlist_t::remove when running headless server
Post by: Matthew on July 09, 2021, 03:57:10 PM
Quote from: Rollmaterial on July 09, 2021, 02:52:26 PM
What I'm describing doesn't seem to occur when removing the entire tunnel by using the general remove tool on a portal. It only occurs with the way removal tool.

I'd suggest you open a separate bug report with steps to reproduce. This bug report is about sync_step which I think (I mioght be wrong) handles routine movement of convoys, not way construction/destruction. I suggest you also skim-read these (https://forum.simutrans.com/index.php/topic,20718.msg196044/topicseen.html#msg196044) two (https://forum.simutrans.com/index.php/topic,20902.0.html) bug reports. Also, please note whether the affected tunnels have Public right of way (PROW), because that could be important, since the PROW code was recently changed.
Title: Re: Re: Data race in objlist_t::remove when running headless server
Post by: RESTRICTED ACCOUNT on July 09, 2021, 04:06:34 PM
Quote from: Rollmaterial on July 08, 2021, 10:24:58 PMDoes this cause corruption when removing tunnels? Asking to avoid potential duplicate bug reports.
This seems to be another bug. I haven't looked into it because I don't have time, but I'm guessing it's a merge retake error.

https://github.com/Ranran-the-JuicyPork/simutrans-extended/commit/c7fcb7b183fac385acedcc564267ac47368d8fcf
(https://github.com/Ranran-the-JuicyPork/simutrans-extended/commit/c7fcb7b183fac385acedcc564267ac47368d8fcf)I don't know why the result of cherry picking this commit again was as this (https://github.com/Ranran-the-JuicyPork/simutrans-extended/commit/840dff0a96981aa03290383aebd18f44235a1733), but I'm guessing it was the cause.
Title: Re: Re: Data race in objlist_t::remove when running headless server
Post by: Matthew on July 09, 2021, 07:10:53 PM
Quote from: Ranran on July 09, 2021, 04:06:34 PM
This seems to be another bug. I haven't looked into it because I don't have time, but I'm guessing it's a merge retake error.

https://github.com/Ranran-the-JuicyPork/simutrans-extended/commit/c7fcb7b183fac385acedcc564267ac47368d8fcf
(https://github.com/Ranran-the-JuicyPork/simutrans-extended/commit/c7fcb7b183fac385acedcc564267ac47368d8fcf)I don't know why the result of cherry picking this commit again was as this (https://github.com/Ranran-the-JuicyPork/simutrans-extended/commit/840dff0a96981aa03290383aebd18f44235a1733), but I'm guessing it was the cause.


That commit was announced in this post (https://forum.simutrans.com/index.php/topic,20809.msg195029.html#msg195029).