The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: ceeac on September 12, 2022, 06:07:51 AM

Title: Addons are loaded by default
Post by: ceeac on September 12, 2022, 06:07:51 AM
Not sure if this is a bug or a documentation issue...

When Simutrans is started with the '-objects' command line parameter, addons are loaded by default. This is contrary to the documentation in readme.txt and also when Simutrans is started with the '-help' parameter. Should addons be loaded by default or not?
Title: Re: Addons are loaded by default
Post by: prissi on September 23, 2022, 02:07:53 AM
Should not load with default.
Title: Re: Addons are loaded by default
Post by: ceeac on September 24, 2022, 06:58:32 AM
Okay, fixed in r10757.
Title: Re: Addons are loaded by default
Post by: Dwachs on November 10, 2022, 07:56:17 PM
Not completely fixed. If a start a game with -addons, then start another game without using -addons/-noaddons it will start with addons again. So this setting survives till the next start of the program.

Title: Re: Addons are loaded by default
Post by: prissi on November 11, 2022, 04:46:47 AM
Loading a game will not load/unload the addons. However, at this point the addons are loaded and can be used. Hence, the game should reflect this by saving as "loaded with addons".

Or did I understood this wrong?
Title: Re: Addons are loaded by default
Post by: Dwachs on November 11, 2022, 06:24:10 AM
Start simutrans with '-addons' option. Close it. Start Simutrans without '-addons' / '-noaddons'. Now Simutrans starts with addons. Somehow the setting 'with-private-paks' survives and will not be reset to the default in the next program start.

That is, doing the following in a terminal:
> ./sim -objects pak -addons   # will start with addons
> ./sim -objects pak           # will start with addons
> ./sim -objects pak -noaddons # will start without addons
> ./sim -objects pak           # will start without addons
A call without addons/noaddons takes the addons-setting from the previous run. No savegames need to be loaded.
Title: Re: Addons are loaded by default
Post by: ceeac on November 13, 2022, 08:53:15 AM
Quote from: Dwachs on November 11, 2022, 06:24:10 AMA call without addons/noaddons takes the addons-setting from the previous run. No savegames need to be loaded.
Should be fixed with the next savegame version bump (see r10802).
Title: Re: Addons are loaded by default
Post by: prissi on November 14, 2022, 12:17:30 PM
That flag was once thought to tell at loading time without given a pak if the pak with addons too should be also automatically be loaded. Since that functionality is apparently not used much, removing it may be ok. If one wants to keep that functionality, then we may need two variables.