BB5 is the first time that I have played in Caledonia and I noticed that it doesn't have many tenements, the characteristic housing stock of Scotland's great cities (https://en.wikipedia.org/wiki/Tenement#Edinburgh_and_Glasgow). So this PR (https://github.com/jamespetts/simutrans-pak128.britain/pull/156) quadruples the chance of tenements being built in Caledonia, while making them four times less likely to appear in the regions representing England and Wales. I have left Erin as it is: Dublin did have some Scottish-style tenements built by the Iveagh Trust (https://en.wikipedia.org/wiki/Iveagh_Trust), but Irish folk history uses the term much more broadly to mean any poor-quality housing, rather than tenements in the Scottish and pakset sense. I don't think they were common in the rest of Ireland (I don't remember seeing any in my time in Belfast and a BBC educational site (https://www.bbc.co.uk/legacies/work/northern_ireland/ni_8/article_4.shtml) says flatly that "[t]here were no tenement houses in Belfast").
I also fixed a typo in comments and one which meant some of Spenk009's lovely cottages have never been built. ::'(
Thank you for this. I think that we are missing the English translation texts for the new buildings?
Quote from: jamespetts on May 11, 2023, 10:46:06 AMThank you for this. I think that we are missing the English translation texts for the new buildings?
Alas they are not new buildings; they are Archon's buildings duplicated with different regional settings. I have given them separate names as you requested since it's no trouble to do so and also corrected a typo.
Also, there were previously duplicate copies of the 1880 tenement building. IIRC this was a way to get more variety in buildings before we had the
chance= setting, right? I have removed the duplicate, but when I want to add it to compat.tab, I checked and found that it's already there. So it's now there as a chain (A→B, B→C). Is that OK?
EDIT: I have now separated this part into a separate commit (f90c755). Implementing this on top of the other changes would mean Caledonia's chance of tenements would be 200% of the previous level, Erin's would be 50%, and the other regions' would be roughly 12.5%. With hindsight we should probably just leave the duplicate entry there in order to keep the balance of levels that I originally intended as it's not worth the risk of breaking things in compat.tab.