The International Simutrans Forum

Simutrans Extended => Patches/pull requests for consideration => Simutrans-Extended development => Incorporated patches/merged pull requests => Topic started by: Matthew on August 23, 2023, 09:22:42 PM

Title: PR#624: More specific messages for industry
Post by: Matthew on August 23, 2023, 09:22:42 PM
When a Factory opens, closes or changes its contracts, Simutrans-Extended posts a message. But only the chain extension messages mention the location of the industry. In other cases, you don't know whether or not that Factory is near your network, so you have to check every such message. On a large map, there can be dozens of messages just for one month and checking every one isn't particularly fun  :::) :
(https://i.imgur.com/igaY4N6.png)

PR#624 (https://github.com/jamespetts/simutrans-extended/pull/624) is a small patch that adds locations to more of the industrial messages. If an industry is inside a city, it will state that:
(https://i.imgur.com/nFnbddN.png)

And if not, then it will use the nearest city:
(https://i.imgur.com/HeQuq6y.png)

If it can't find any cities then it will fall back to the existing messages.

Following the practice of other recent patches, I have added the new strings (but not the fallback ones) to text/en.tab.

I have tested it in English by running single player for several months in different decades and using it as a client in an online game.

I now have a SimuTranslator login, but I couldn't find a tutorial explaining how to add strings so that they are available for translation ("base texts"?). I guess from an old thread (https://forum.simutrans.com/index.php/topic,16696.0.html) that I should just add a new .dat file to the root of the repo in the same format as the others. Is that correct?

Title: Re: PR#624: More specific messages for industry
Post by: makie on August 31, 2023, 08:28:19 AM
@Matthew
Please retry
Title: Re: PR#624: More specific messages for industry
Post by: Matthew on August 31, 2023, 03:19:42 PM
Quote from: makie on August 31, 2023, 08:28:19 AM@Matthew
Please retry

Thank you Makie! You have given me the permission that I needed.

James, the new strings have now been uploaded into SimuTranslator. The base texts file has now been removed from the PR.
Title: Re: PR#624: More specific messages for industry
Post by: jamespetts on September 07, 2023, 06:07:05 PM
Excellent, thank you: now incorporated.