The International Simutrans Forum

Development => Patches & Projects => Topic started by: prissi on March 26, 2024, 05:47:50 AM

Title: r11101 expanded numberinput
Post by: prissi on March 26, 2024, 05:47:50 AM
I would like to revert r11101. To me, the now extremely wide numberput boxes look very ugly and the tiny number is almost lost in them. And the arrows are very far apart for easy mouse changing.

Title: Re: r11101 expanded numberinput
Post by: Roboron on March 26, 2024, 02:15:03 PM
I appreciate the fact that they are aligned and have the same size, but I have to agree they are too wide (at least the second ones). Ideally they would take the same size of the widest input number.
Title: Re: r11101 expanded numberinput
Post by: prissi on March 26, 2024, 02:22:12 PM
For that, one would need to add a third row of dummy objects ... can be done, but would need to be done for each of the affected dialogues. (Also the display settings i.e for traffic or map are now very wide.)
Title: Re: r11101 expanded numberinput
Post by: ceeac on March 31, 2024, 06:00:11 PM
IMO the stretchable numberinputs look much nicer, this is the primary reason why I changed it. Also, other components like comboboxes or textinputs are stretchable too, so it is more consistent if numberinputs are stetchable, too.

Quote from: prissi on March 26, 2024, 02:22:12 PMFor that, one would need to add a third row of dummy objects ... can be done, but would need to be done for each of the affected dialogues. (Also the display settings i.e for traffic or map are now very wide.)
It would indeed be a larger change to check and change all the dialogues containing numberinputs. I think it would be best to revert the change right now (since reverting to the previous behaviour does not break anything), and then redo the change properly after the release since I want to focus on GUI improvements after the release anyway.
Title: Re: r11101 expanded numberinput
Post by: isidoro on March 31, 2024, 11:34:16 PM
In my opinion, aligned input fields look much nicer than irregular ones.
Title: Re: r11101 expanded numberinput
Post by: RESTRICTED ACCOUNT on April 01, 2024, 10:48:16 PM
(https://i.imgur.com/akafEY6.png)
I think that by properly combining table and gui_fill_t, you can maintain alignment while preventing the width from becoming too wide.
The red frame is a table with two horizontal rows.
Then put gui_fill_t in the blue frame.
Title: Re: r11101 expanded numberinput
Post by: prissi on April 02, 2024, 08:41:09 AM
I think this is the way ceeac wants to go and as long term goal this is certainly the best way. Alternatively, one could give the numberinput a default minimum width of 4 digits, and then they would align nicer, at least the smaller numbers.

r11105 enforces five digits minimum width. Maybe this should be a themeable parameter?