The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: Andarix on May 04, 2024, 09:59:26 PM

Title: r11155 - built oil rigs
Post by: Andarix on May 04, 2024, 09:59:26 PM
During the current game, 2 oil rigs were built one inside the other.

oilrigs_built.png
Title: Re: r11155 - built oil rigs
Post by: Yona-TYT on May 04, 2024, 10:59:35 PM
A very nice bug 😊
Title: Re: r11155 - built oil rigs
Post by: prissi on May 05, 2024, 02:24:35 AM
This should only happen if there is a zero spacing given (in principle) as there is an exclusion map. But maybe this does not work on water.
Title: Re: r11155 - built oil rigs
Post by: ceeac on June 03, 2025, 07:18:14 AM
r11714 adds a (currently failing) test for this bug.

EDIT: Should be fixed in r11716.
Title: Re: r11155 - built oil rigs
Post by: prissi on June 03, 2025, 07:58:29 AM
Thank you.

I still wonder, there should be an exclusion area map around each factory. (fab_map) and is_factory_at() should return true in the factory_site_searcher_t(). So I guess either the factory map is not properly updated or there is another issue hidden.

EDIT:
Indeed, the factory exclusion zone was not obeyed for water factories. Also, the factory is_area_ok had an one off error in w and h for checking place size for the actual factory building.