The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: Yona-TYT on May 07, 2024, 11:11:38 AM

Title: Pak192.comic not downloading
Post by: Yona-TYT on May 07, 2024, 11:11:38 AM


The download manager for paksets is not working specifically with pak192.comic, maybe the link is wrong?.

Captura desde 2024-05-07 07-08-54.png
Title: Re: Pak192.comic not downloading
Post by: Roboron on May 07, 2024, 05:56:19 PM
I can't download any of the paksets hosted at Sourceforge (like pak192.comic):

Message: network_open_address():        Preparing to bind address: ::
Message: network_open_address():        Potential local address: ::
Message: network_open_address():        Potential remote address: 204.68.111.105
Message: network_open_address():        Preparing to bind address: 0.0.0.0
Message: network_open_address():        Potential local address: 0.0.0.0
Message: network_open_address():        Potential remote address: 204.68.111.105
Message: network_http_get_file():       HTTP/1.1 302 Found
Server: nginx
Date: Tue, 07 May 2024 18:13:10 GMT
Content-Type: text/plain; charset=UTF-8
Content-Length: 201
Connection: keep-alive
location: http://deac-riga.dl.sourceforge.net/project/simutrans/pak32.comic/pak32.comic%20for%20102-0/pak32.comic_102-0.zip?viasf=1
content-disposition: attachment; filename="pak32.comic_102-0.zip"
set-cookie: sf_mirror_attempt=simutrans:deac-riga:pak32.comic/pak32.comic%20for%20102-0/pak32.comic_102-0.zip; Max-Age=120; Path=/; expires=Tue, 07-May-2024 18:15:10 GMT


Warning: Pakset download failed with:   Unknown redirect..

A unfortunate change by Sourceforge? Does this happen to you as well?
Title: Re: Pak192.comic not downloading
Post by: Yona-TYT on May 07, 2024, 07:06:13 PM
You know what I think, that I should implement a kind of repository so that the pakset links reside in a file outside the executable, then every time the [install] button is pressed an update would automatically be searched for said list.

This would give us the great advantage of fixing or updating a link in case of any failure or inconvenience.
Title: Re: Pak192.comic not downloading
Post by: TurfIt on May 07, 2024, 09:01:31 PM
Quote from: Roboron on May 07, 2024, 05:56:19 PMI can't download any of the paksets hosted at Sourceforge (like pak192.comic):

Message: network_http_get_file():       HTTP/1.1 302 Found

location: http://

A unfortunate change by Sourceforge? Does this happen to you as well?
No. Whatever sourceforge server you get directed to is returning "location". I get "Location" which is what Simutrans expects. However, per HTTP spec, the header names are supposed to be case insensitive, so need to change Simutrans away from strstr().  strcasestr() would be good except apparently for MSVC...
Title: Re: Pak192.comic not downloading
Post by: prissi on May 08, 2024, 09:37:49 AM
STRCASESTR now added in r11187 should fix this.
Title: Re: Pak192.comic not downloading
Post by: Roboron on May 08, 2024, 04:18:09 PM
Yes, I confirm I can now download paksets from sourceforge (including pak192.comic). Thanks!

Moving to solved. Yet another thing for the bugfix release...