Text only | Text with Images

The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: Andarix on May 26, 2024, 06:39:46 PM

Title: r11240 - add player ranking
Post by: Andarix on May 26, 2024, 06:39:46 PM
new files missing

Quote...
2024-05-26T18:28:53.4119116Z /home/runner/work/simutrans/simutrans/src/simutrans/gui/simwin.cc:77:10: fatal error: player_ranking_frame.h: No such file or directory
2024-05-26T18:28:53.4121327Z    77 | #include "player_ranking_frame.h"
Title: Re: r11240 - add player ranking
Post by: prissi on May 27, 2024, 12:34:44 AM
Oh indeed, that is still sitting on my laptop at home ... So it will need another 10 hours to be fixed.
Title: Re: r11240 - add player ranking
Post by: Andarix on May 27, 2024, 02:16:02 PM
r11242

linux
Quote...
2024-05-27T13:59:21.5563270Z /usr/bin/ld: CMakeFiles/simutrans.dir/src/simutrans/gui/simwin.cc.o: in function `rdwr_all_win(loadsave_t*)':
2024-05-27T13:59:21.5565308Z simwin.cc:(.text+0x30df): undefined reference to `player_ranking_frame_t::player_ranking_frame_t(unsigned char)'
2024-05-27T13:59:21.5567091Z /usr/bin/ld: CMakeFiles/simutrans.dir/src/simutrans/tool/simmenu.cc.o: in function `dialog_player_ranking_t::init(player_t*)':
2024-05-27T13:59:21.5568586Z simmenu.cc:(.text._ZN23dialog_player_ranking_t4initEP8player_t[_ZN23dialog_player_ranking_t4initEP8player_t]+0x21): undefined reference to `player_ranking_frame_t::player_ranking_frame_t(unsigned char)'
2024-05-27T13:59:21.5569821Z collect2: error: ld returned 1 exit status
2024-05-27T13:59:21.5572399Z make[2]: *** [CMakeFiles/simutrans.dir/build.make:5770: simutrans/simutrans] Error 1

windows compile
Title: Re: r11240 - add player ranking
Post by: RESTRICTED ACCOUNT on May 27, 2024, 11:02:56 PM
 :)
Title: Re: r11240 - add player ranking
Post by: Andarix on May 28, 2024, 03:59:15 AM
The text is there, but the selection field is missing.

Screenshot 2024-05-28 055812.png
Title: Re: r11240 - add player ranking
Post by: prissi on May 28, 2024, 05:56:51 AM
@Andarix
Thanks for the update of the translations.

@Ranran
I had a hard time figure out why the order in my testgames did not work until I saw that one needs a sin64 for the comparison to avoid overflows ... I added the year selection manually since I was not sure from which branch to look at your many branches.
Title: Re: r11240 - add player ranking
Post by: Andarix on May 28, 2024, 06:16:43 AM
r11249 compile all OS
Title: Re: r11240 - add player ranking
Post by: RESTRICTED ACCOUNT on May 28, 2024, 09:43:03 AM
 :-[
Title: Re: r11240 - add player ranking
Post by: prissi on May 28, 2024, 12:02:19 PM
I wonder if the arrangement with the graph to the right is not nice to the eyes. Also standard lacks quite a few statistics extended has, so my version is necessarily poorer in functionality.

Also, I thought to add some vanity like the records (after saving them inside the game to avoid them constantly reoccurring after each reload.) And probably should achievement, should we decide to do any single game related achievements.
Text only | Text with Images