The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: Andarix on May 28, 2024, 06:35:30 AM

Title: r11249 - player ranking
Post by: Andarix on May 28, 2024, 06:35:30 AM
With a new map, the chart is not limited to the right.

Not all activated players are listed either.
[de]Es werden auch nicht alle aktivierten Spieler gelistet.[/de]

Screenshot 2024-05-28 083222.png
Title: Re: r11249 - player ranking
Post by: prissi on May 28, 2024, 01:09:15 PM
There is not much that can be done as the chart starts the previous year.
Title: Re: r11249 - player ranking
Post by: RESTRICTED ACCOUNT on May 28, 2024, 01:40:42 PM
 :P
Title: Re: r11249 - player ranking
Post by: Andarix on May 28, 2024, 02:43:59 PM
Quote from: Ranran on May 28, 2024, 01:40:42 PMAt least in the extended version, newly born players cannot enter the list with the GUI open.
The player should reopen the UI or the UI should automatically detect and update it.
So it needs to be fixed...

Ranking opened after activating all players.
Title: Re: r11249 - player ranking
Post by: Andarix on May 28, 2024, 06:10:08 PM
r11250

If you select 1928, shouldn't the values at 1928 of the chart be displayed to the right?
1928 is the starting year

Screenshot 2024-05-28 200658.png
Title: Re: r11249 - player ranking
Post by: Andarix on May 28, 2024, 08:37:10 PM
r11250

Apparently the chart no longer scales to the years.

The list of years will not be expanded either. 1928 and 1929 should now be available to choose from.

Screenshot 2024-05-28 223331.png
Title: Re: r11249 - player ranking
Post by: RESTRICTED ACCOUNT on May 28, 2024, 10:21:14 PM
 :P
Title: Re: r11249 - player ranking
Post by: Andarix on May 29, 2024, 07:48:42 AM
r11250

'Step timeline one year' expands chart and year list

Screenshot 2024-05-29 094228.png
Title: Re: r11249 - player ranking
Post by: prissi on May 29, 2024, 08:49:10 AM
The window should detect players and expand on the new year as soon as karte_t updates "last_year" May<be this is not immediately updates under certain conditions, I will investigate.

The list deliberately hides player which have zero in all years in a certain category. THis was a design decision by ranran which I like as if I have no ship transport, why should I appear in a ranking.

If there is only the current year, indeed, maybe the chart should display the current numbers.

Lots of things to check.

And offtopic, but creating a new company should send a game message around. That should be added.
Title: Re: r11249 - player ranking
Post by: Andarix on May 29, 2024, 09:26:38 AM
Speculation

Either the year 1930 is used as the default or the chart is linked to the Simutrans player. Now that the Simutrans player is active, the chart and year list is expanded.

Screenshot 2024-05-29 112221.png
Title: Re: r11249 - player ranking
Post by: prissi on May 29, 2024, 02:30:56 PM
The chart has a span which needs updated before adding new data. I added also support for comparison in the running year in r11252.
Title: Re: r11249 - player ranking
Post by: Andarix on May 29, 2024, 06:22:08 PM
r11253 works fine

thank you