This is on the (misnamed) sync-cleanups branch. This resynchronizes with Standard. There was no reason to remove the integer overflow check; overflow checks are good; they are cheap computationally. We may at some point have large ticks_per_month values and very long games and may risk overflowing sint64; there is no harm in leaving a check in place and potential harm in commenting it out.
Quote from: neroden on June 04, 2024, 02:54:21 PMThis is on the (misnamed) sync-cleanups branch. This resynchronizes with Standard. There was no reason to remove the integer overflow check; overflow checks are good; they are cheap computationally. We may at some point have large ticks_per_month values and very long games and may risk overflowing sint64; there is no harm in leaving a check in place and potential harm in commenting it out.
Thank you - now incorporated.