The International Simutrans Forum

PakSets and Customization => Pak128 => Topic started by: ceeac on November 02, 2024, 09:26:03 AM

Title: Invalid dat fixes
Post by: ceeac on November 02, 2024, 09:26:03 AM
PR #30 (https://github.com/simutrans/pak128/pull/30) cleans up some dat files which caused some warnings during pakset compilation.
Title: Re: Invalid dat fixes
Post by: Yona-TYT on November 02, 2024, 09:30:30 AM
Quote from: ceeac on November 02, 2024, 09:26:03 AMPR #30 (https://github.com/simutrans/pak128/pull/30) cleans up some dat files which caused some warnings during pakset compilation.
Merge  (https://github.com/simutrans/pak128/commit/c9e32778be0964d5a93b3f48f9c288a272cc6950)
Title: Re: Invalid dat fixes
Post by: ceeac on November 03, 2024, 12:59:21 PM
Another cleanup PR: #32 (https://github.com/simutrans/pak128/pull/32) merges dats referencing the same PNG into one (not all of them, I have not touched the overhead catenary dats for example).
The main reason for this is to work towards being able to compile the pakset incrementally in the future.
Title: Re: Invalid dat fixes
Post by: Yona-TYT on November 03, 2024, 09:34:43 PM
Quote from: ceeac on November 03, 2024, 12:59:21 PMAnother cleanup PR: #32 (https://github.com/simutrans/pak128/pull/32) merges dats referencing the same PNG into one (not all of them, I have not touched the overhead catenary dats for example).
The main reason for this is to work towards being able to compile the pakset incrementally in the future.

Merge (https://github.com/simutrans/pak128/commit/bb60ad319121e2f8418d23ed7c282eaaf92eab5b)
Title: Re: Invalid dat fixes
Post by: prissi on November 04, 2024, 01:31:06 AM
Some of those fixes are not very consequent. The stations and bus stops were separated into individual files while the trams were merged. Since those stops were from the same author, I think keeping them merged would have been ok too.