The International Simutrans Forum

Simutrans Extended => Pak128.Britain-Ex Bug Reports => Pak128.Britain-Ex => Simutrans-Extended paksets => Pak128.Britain-Ex closed bug reports => Topic started by: Matthew on March 16, 2025, 04:00:48 PM

Title: 1852 post box does not appear
Post by: Matthew on March 16, 2025, 04:00:48 PM
Steps to reproduce

1. Start or load a game in January 1852
2. Fast forward
3. At the start of February 1852, you will see a message stating that a Post Box is now available.

Expected results

A Post Box appears in the Road menu.

Actual results

There is no Post Box in the Road menu.

Observations

I believe that this should be the green Post Box introduced in this thread (https://forum.simutrans.com/index.php/topic,6750.msg144145.html#msg144145). The internal name is LoadingBay1852.

I believe the problem may have been introduced in this commit (https://github.com/jamespetts/simutrans-pak128.britain/commit/fb036dcb83dbd84fe525543c84ade512cdb4aebd) which appears to have accidently removed the green Post Box menu icon.

The same bug was also reported on Steam here (https://steamcommunity.com/app/434520/discussions/0/632295528254705892/?tscn=1739465929).
Title: Re: 1852 post box does not appear
Post by: Matthew on March 16, 2025, 05:15:01 PM
I have attempted to add the missing menu icon and there is a PR here (https://github.com/jamespetts/simutrans-pak128.britain/pull/168) but it has not been tested because I don't have a working makeobj.

As I am still stuck with my potato laptop, I had to use a barebones editing program so it really needs testing before merging.

Edit 17/III/25: I got makeobj working to test this. It was missing a few pixels, but that's been fixed and the PR updated, so it's now good to go.
Title: Re: 1852 post box does not appear
Post by: jamespetts on March 21, 2025, 09:15:00 PM
Quote from: Matthew on March 16, 2025, 05:15:01 PMI have attempted to add the missing menu icon and there is a PR here (https://github.com/jamespetts/simutrans-pak128.britain/pull/168) but it has not been tested because I don't have a working makeobj.

As I am still stuck with my potato laptop, I had to use a barebones editing program so it really needs testing before merging.

Edit 17/III/25: I got makeobj working to test this. It was missing a few pixels, but that's been fixed and the PR updated, so it's now good to go.
Thank you for that - now incorporated.