The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: CannonBall7 on April 05, 2025, 07:31:04 PM

Title: MacBundle.cmake: missing slash in path
Post by: CannonBall7 on April 05, 2025, 07:31:04 PM
A few years ago, two lines in MacBundle.cmake had ${CMAKE_SOURCE_DIR} replaced with ${SOURCE_DIR}. That commit also dropped the slash that came after. That now prevents the Mac version from being built in some situations, e.g. Homebrew, which fails during the configuration step:

CMake Error at cmake/MacBundle.cmake:6 (file):
  file failed to open for reading (No such file or directory):

    /private/tmp/simutrans-20250405-80604-xyhipysrc/simutrans/simversion.h
Call Stack (most recent call first):
  CMakeLists.txt:380 (include)

The change can be found here: https://github.com/simutrans/simutrans/commit/fe2941b2d4837dd226a5b2374e3652de7af686b8
Title: Re: MacBundle.cmake: missing slash in path
Post by: prissi on April 06, 2025, 01:40:17 AM
Can you be a little more specific of what you want to change? Another slash or getting back so CMAKE_SOURCE_DIR? Because we have no make and all this is trial and error.
Title: Re: MacBundle.cmake: missing slash in path
Post by: ceeac on April 06, 2025, 05:41:15 AM
Judging by the error message, I guess it was the missing path separator. Fixed in r11675.
Title: Re: MacBundle.cmake: missing slash in path
Post by: Roboron on April 06, 2025, 09:23:39 AM
Thank you!