The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: Nazalassa on August 10, 2025, 09:06:33 AM

Title: r11737: Ticker messages in player color have rendering issues
Post by: Nazalassa on August 10, 2025, 09:06:33 AM
When the ticker bar appears because of a new message, the first few pixels of that new message are colored black instead of the correct player color (if it is in a player's color).

Steps to reproduce:

Expected results:
The ticker message should be fully written in the primary player color

Observed results:
The ticker message is written in the player color, except for the first few pixels.

ticker-color-bug.png

Attached is a patch that fixes the bug: when the ticker appears, it does not check whether the message's color is a player color or not (and assumes it is a regular color).
Title: Re: r11737: Ticker messages in player color have rendering issues
Post by: FLN on August 10, 2025, 11:40:58 AM
Occasionally it is not only that one strike of the first letter, but ~20% of the text's beginning part.
Title: Re: r11737: Ticker messages in player color have rendering issues
Post by: Nazalassa on August 10, 2025, 03:44:27 PM
Quote from: FLN on August 10, 2025, 11:40:58 AMOccasionally it is not only that one strike of the first letter, but ~20% of the text's beginning part.

From what I could read from the code, it affects the part of the text that is shown on the very first frame the ticker appears (and only that part). So if simutrans freezes, the message can be already quite far away by the time the ticker appears and its first frame is drawn...
Title: Re: r11737: Ticker messages in player color have rendering issues
Post by: ceeac on August 27, 2025, 06:19:35 AM
Incorporated in 11739.