This changes behaviour to match Standard. Extended behaviour before the PR generates stops like Affcot mezzo stop, Affcot axis stop, Affcot east stop, Affcot village south stop etc. This changes to the streetlist instead, which especially when combined with regions gives a greater variety to stop names.
PR is at https://github.com/jamespetts/simutrans-extended/pull/678
I have never fetched a PR as fast as this one!
OK, that's mainly because I was already on the forum for other reasons, but I am also very bored with the default stop names, especially since some of the magic ones (north/south/east/west) rarely if ever appear, so I end up with every town having X Bridge (even if there isn't a bridge), X Green (even if there isn't any green), etc.
I think it's a matter of preference, rather than right or wrong, but I prefer this patch's behaviour.
BTW there are also changes to the indenting on dozens of other lines in simhalt.cc as well. Was this intentional or was it some kind of IDE feature or linter? It means 'Git Blame' and tools that depend upon on it show this commit as having made the last changes to these lines, which seems suboptimal. I often use such tools to try to search for information here about parts of the code that I don't understand.