The International Simutrans Forum

Simutrans Extended => Simutrans-Extended bug reports => Simutrans-Extended development => Simutrans-Extended closed bug reports => Topic started by: ӔO on June 24, 2011, 03:52:53 AM

Title: [9.9] bug? spacing/scheduling does not seem to save
Post by: ӔO on June 24, 2011, 03:52:53 AM
the spacing/cnv month always seems to revert back to 1 no matter what settings are used in that dialogue box.
Title: Re: [9.9] bug? spacing/scheduling does not seem to save
Post by: Carl on June 24, 2011, 09:31:24 AM
Yep, I'm getting this too.
Title: Re: [9.9] bug? spacing/scheduling does not seem to save
Post by: jamespetts on June 24, 2011, 09:32:22 AM
Thank you for reporting this. Inkelyad - are you able to look into this? AEO - do other changes in that dialogue box (such as max. wait for load and alternate directions) seem to save? Sorry that you are having trouble.
Title: Re: [9.9] bug? spacing/scheduling does not seem to save
Post by: inkelyad on June 24, 2011, 09:53:01 AM
It is problem i reported in neighbour topic.

in wkz_change_line_t::init

sscanf( p, "%c,%hi,%hi", &tool, &line_id, &livery_scheme_index );


You always read livery_scheme_index from tools param.

But, for example, 'g' command don't put it there.
line_management_gui_t::infowin_event(const event_t *ev):

werkzeug_t *w = create_tool( WKZ_LINE_TOOL | SIMPLE_TOOL );
cbuffer_t buf;
buf.printf( "g,%i,", line.get_id() );
fpl->sprintf_schedule( buf );
w->set_default_param(buf);

Title: Re: [9.9] bug? spacing/scheduling does not seem to save
Post by: jamespetts on June 24, 2011, 10:12:23 AM
Ahh - apologies. I did not understand the significance of this point. I shall have to look into that. Thank you for explaining.
Title: Re: [9.9] bug? spacing/scheduling does not seem to save
Post by: ӔO on June 24, 2011, 06:12:18 PM
@james
the other settings seem to save, but the spacing does not.
Title: Re: [9.9] bug? spacing/scheduling does not seem to save
Post by: jamespetts on June 25, 2011, 01:13:36 PM
I have now looked into the matter (thank you, Inkelyad, for finding the problem), and a fix has been applied on my 9.x branch.
Title: Re: [9.9] bug? spacing/scheduling does not seem to save
Post by: inkelyad on June 25, 2011, 09:09:22 PM
I can be dense, but why not like this (https://github.com/inkelyad/simutrans-experimental/commit/5102db076c7665ad63d22f42e21494daac6e4fa8)?

(Start of wkz_change_convoi_t::init same as in Standard, and livery_scheme_index is readed in 'V' case)
Title: Re: [9.9] bug? spacing/scheduling does not seem to save
Post by: jamespetts on June 26, 2011, 10:42:17 AM
Inkelyad,

thank you very much for that - that seems a lot neater! Incorporated into the 9.x branch.
Title: Re: [9.9] bug? spacing/scheduling does not seem to save
Post by: jamespetts on June 26, 2011, 12:18:14 PM
9.10 with this fix incorporated has been released.