The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: Fabio on January 27, 2012, 10:33:15 PM

Title: Schedule dialog & map interaction
Post by: Fabio on January 27, 2012, 10:33:15 PM

This request has been split from here: http://forum.simutrans.com/index.php?topic=9072.msg84571#msg84571
When schedule dialog is open, all TILES marked as stops or way points should be highlighted in red on the map, and a label is shown on the tile with the stop number in schedule.

This would make enormously easier selecting complicated routes and even more editing them afterward.
Title: Re: Schedule dialog & map interaction
Post by: Fabio on January 28, 2012, 09:03:00 PM
I split this post and put it back in Extension Requests, as it seems it has been overlooked.

Is it doable? It would be a great improvement in settin up lines and schedules.
Title: Re: Schedule dialog & map interaction
Post by: prissi on January 28, 2012, 10:32:14 PM
It was not too hard for way tiles on land. Water will not really work well with this.
Title: Re: Schedule dialog & map interaction
Post by: Fabio on January 28, 2012, 11:28:14 PM
So also this is done? Amazing, I didn't realize it. I'll try next nightlies...
Title: Re: Schedule dialog & map interaction
Post by: Fabio on January 30, 2012, 01:04:50 PM
I'm afraid I didn' see any highlighting in rev. 5158:

(http://i39.tinypic.com/1zczdw4.png) (http://i39.tinypic.com/1zczdw4.png)
Title: Re: Schedule dialog & map interaction
Post by: Dwachs on January 30, 2012, 02:32:00 PM
There is an option in the display settings ...
Title: Re: Schedule dialog & map interaction
Post by: Fabio on January 30, 2012, 02:42:07 PM
Thanks, I overlooked it. And rightfully it's checked by dafault.

BUT I don't see any effect, having it checked or unchecked...
Title: Re: Schedule dialog & map interaction
Post by: Dwachs on January 30, 2012, 02:58:54 PM
Bug: does not work for railroad yet. It is working for road vehicles.
Title: Re: Schedule dialog & map interaction
Post by: Fabio on January 30, 2012, 03:31:38 PM
Wow, thank you for discovering.

For which way types should it work in its final form?

Roads
Tracks, tram tracks, monorails, etc
Airports?
Sea, canals and rivers?

Prissi said it doesn't look good on water, otoh for consistency it should be added also there...
Title: Re: Schedule dialog & map interaction
Post by: Fabio on January 30, 2012, 04:03:11 PM
Sorry for the double post.

I tried now the roads, it works like charm!

I'm requesting one more thing: the stop/waypoint currently selecte in schedule dialog should be highlighted in a different color (e.g. orange vs red) so I can see before which one I'm inserting a new stop and so on.

Numbering would have been great too, but maybe too hard to implement. At least with orange highlighting of the selected stop, I can click on the schedule list and see which is which.
Title: Re: Schedule dialog & map interaction
Post by: prissi on January 30, 2012, 04:43:19 PM
This is not so easy possible, as I used up all available bits. I could put a marker there.
Title: Re: Schedule dialog & map interaction
Post by: Fabio on January 30, 2012, 05:01:18 PM
A marker on every stop with the number (eg: 4) and number + something else for the selected one (eg: 4 *)?

This would be awesome!
Title: Re: Schedule dialog & map interaction
Post by: prissi on January 30, 2012, 10:13:19 PM
fabio, just to note: Thou have become greedy. I will henceforth ignore your not so humble requests for a fortnight ;)
Title: Re: Schedule dialog & map interaction
Post by: Fabio on January 30, 2012, 10:52:19 PM
You know: when discussion and actual work are started on a topic, I like to hammer the iron till it's hot ;)
Title: Re: Schedule dialog & map interaction
Post by: Dwachs on January 31, 2012, 07:38:04 AM
Highlighted ways cannot be seen if the stop is on a station tile. Maybe highlkight the station graphics, too?
Title: Re: Schedule dialog & map interaction
Post by: Fabio on January 31, 2012, 09:03:15 AM
It seems logical...

I think these schedule dialog changes will improve lines management dramatically..Thank you all for looking into this.
Title: Re: Schedule dialog & map interaction
Post by: prissi on January 31, 2012, 09:38:30 AM
One could everything non-moving on a tile. Easy.
Title: Re: Schedule dialog & map interaction
Post by: Fabio on February 03, 2012, 03:02:03 PM
I tested it again today:


Quote
Revision 5164
2012-01-30 Revision 5164 2012-01-30 23:10:17
prissi modified 6 items in /simutrans/trunk
   gui/fahrplan_gui.h
   dings/baum.cc
   dings/baum.h
   simdings.cc
   boden/boden.cc
   gui/fahrplan_gui.cc
FIX: better highliting of schedule on tracks


It's awesome, I think it's one of the best additions for UI in a while!


I still need to report a couple of issues:


(http://i44.tinypic.com/2e4jm9t.png) (http://i44.tinypic.com/2e4jm9t.png)


The stop sign doesn't dirty the tile above, so when you move it, a part of it remains there (graphic glitch)


This however doesn't happen on sea, beacuse of its animation ;)


(http://i41.tinypic.com/1r22p0.png) (http://i41.tinypic.com/1r22p0.png)


Stop sign gets hidden by the roof of the station, if any. I'm afraid this can't be helped.


(http://i44.tinypic.com/2i6gweb.png) (http://i44.tinypic.com/2i6gweb.png)




Finally, if all not moving objects get highlighted, why here only the way and not the station as well?






Anyway, many screenshots to show the wonders of this change!!!


Than you very much, Prissi!
Title: Re: Schedule dialog & map interaction
Post by: prissi on February 03, 2012, 03:32:13 PM
On water things cannot be done much better; but now highliting everything on a tile (Be prepared for strange looking oil rigs though.)
Title: Re: Schedule dialog & map interaction
Post by: Fabio on February 03, 2012, 04:28:22 PM
Thank you, I'll check in next nightly (also the glitch)
Title: Re: Schedule dialog & map interaction
Post by: Fabio on February 04, 2012, 11:37:32 AM
Checked today:


The station highlighting is great! Thank you!


But the display glitch is still there:


Quote
(http://i44.tinypic.com/2e4jm9t.png) (http://i44.tinypic.com/2e4jm9t.png)


The stop sign doesn't dirty the tile above, so when you move it, a part of it remains there (graphic glitch)

Moving the current stop in schedule list moves it on the map, but a part of the marker is left behind.

Just to report it ;)


(The screenshot is old as the problem remained, but I tested against 5185 8))
Title: Re: Schedule dialog & map interaction
Post by: sdog on February 04, 2012, 09:03:52 PM
prissi, that's brilliant!
Title: Re: Schedule dialog & map interaction
Post by: swed on February 05, 2012, 01:50:32 PM
Wow, great addition ! Thanks !

Here are 2 related highlight issues, from last svn revision :
- Convoi frame : click 'schedule', change line in combobox, close windows : halts stay highlighted after all windows are closed ; see screenshot1.jpg.
- Line edit frame : highlight problem in halt list ; see screenshot2.jpg.

Bye !