The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: Dwachs on February 05, 2012, 09:14:17 AM

Title: simgraph8.cc
Post by: Dwachs on February 05, 2012, 09:14:17 AM
Compiling with the 8bit graphics is seriously broken. I am tempted to delete this file. In this way, we easily get rid of a lot of double code in simgraph8.cc vs simgraph16.cc  :P

Any opinions?
Title: Re: simgraph8.cc
Post by: prissi on February 05, 2012, 07:49:17 PM
It was once made for phones. But since those have also 32 bit graphics: Ok. Same it then true for the x-window backend, since this only works with 8 bit ...
Title: Re: simgraph8.cc
Post by: Ashley on February 05, 2012, 11:40:32 PM
May as well remove it, it's obsolete for the Mac/iOS platform.
Title: Re: simgraph8.cc
Post by: Spike on February 06, 2012, 02:28:40 PM
I also don't hink I'll have a use for it anymore. And if, then the SVN always has the latest used version to be retrieved later.
Title: Re: simgraph8.cc
Post by: Dwachs on February 10, 2012, 08:44:02 AM
simgraph8 bit the dust in r 5249.
Title: Re: simgraph8.cc
Post by: isidoro on February 10, 2012, 01:15:43 PM
Rest In Peace.

Title: Re: simgraph8.cc
Post by: Ters on February 10, 2012, 08:41:59 PM
simsys_x8.cc also becommes obsolete because of this. 8 should also be removed from the list of possible colour depths in the Makefile. There is also code for 8 bit graphics in other files, but fixing the Makefile is more important since it will give a clear warning that COLOUR_DEPTH=8 is gone rather than a file not found error.
Title: Re: simgraph8.cc
Post by: Dwachs on February 10, 2012, 08:50:31 PM
Thanks for the hint. Did the changes in r5251.
Title: Re: simgraph8.cc
Post by: prissi on February 10, 2012, 09:05:10 PM
simsys_x8.cc has code for 15 bit colors too. And it might be useful for the openGL version of Ters.
Title: Re: simgraph8.cc
Post by: Ters on February 10, 2012, 10:28:24 PM
Quote from: prissi on February 10, 2012, 09:05:10 PM
simsys_x8.cc has code for 15 bit colors too. And it might be useful for the openGL version of Ters.

Maybe it has, but since the Makefile included it by adding the file  simsys_x$(COLOUR_DEPTH).c to the source file list, that code would not be used.

And I might not get around to writing any Linux code until easter or summer, since I left my Linux computer behind in my old room when I moved out. That is unless somebody comes up with a text only version of Simutrans.
Title: Re: simgraph8.cc
Post by: Markohs on February 10, 2012, 10:45:50 PM
The OpenGL version will be based on simsys_s.cc I think, since we use SDL and all that parts are already written there. So imo you can relete symsys_8