The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: Spike on February 27, 2012, 03:12:19 PM

Title: Error report for normal operation?
Post by: Spike on February 27, 2012, 03:12:19 PM
I think these are no errors, but still the log files says they are and need reporting. I think the real error is a wrong error level in logging and/or a wrong treatment of the condition (which is normal for the moment just before loading a pak set - the mini skin pak supplied with Simutrans has no ground.Outside.pak, and doesn't need it).

Simutrans version 111.2 Nightly from Feb  8 2012 r0003
Message: simmain::main():    Version: 111.2 Nightly  Date: Feb  8 2012
Message: Debuglevel:    3

[snip]

Message: obj_reader_t::read_file():    filename='skin/ground.Outside.pak'
ERROR: obj_reader_t::read_file():    reading 'skin/ground.Outside.pak' failed!
Please report all errors to
team@64.simutrans.com
ERROR: obj_reader_t::load():    ground.Outside.pak not found, cannot guess tile size! (driving on left will not work!)
Please report all errors to
team@64.simutrans.com
Message: obj_reader_t::load():    reading from 'skin/'
Message: obj_reader_t::read_file():    filename='skin/menu.WindowSkin.pak'
Message: obj_reader_t::read_file():    read 1 blocks, file version is 3eb
Message: obj_reader_t::read_file():    filename='skin/ground.Outside.pak'
ERROR: obj_reader_t::read_file():    reading 'skin/ground.Outside.pak' failed!
Please report all errors to
team@64.simutrans.com
ERROR: obj_reader_t::load():    ground.Outside.pak not found, cannot guess tile size! (driving on left will not work!)
Please report all errors to
team@64.simutrans.com
Message: obj_reader_t::load():    reading from 'skin/'
Message: simmain:    simgraph_init disp_width=704, disp_height=560, fullscreen=0
Message: system_open(SDL):    SDL realized screen size width=704, height=560 (requested w=704, h=560)
Message: simmain:    .. results in disp_width=704, disp_height=560

[snip]

Title: Re: Error report for normal operation?
Post by: Dwachs on February 27, 2012, 08:00:57 PM
Oh yes those debug warning levels needs to be adjusted.

What should be reported as error ? what qualifies for a warning ?

I think errors should be triggered if a condition is found to be true that should not be true at all, i.e. caught malfunctions, which should be reported in the forum.

Warnings should be triggered if an unusual condition is found, but the program has code to deal with it.

What do you think?
Title: Re: Error report for normal operation?
Post by: Spike on February 27, 2012, 09:35:05 PM
Warning: a state differs from programmers expectation, but most likely allows the program to continue.
Error: a state is clearly wrong. It might still allow the program to continue.
Fatal: a state is wrong and the program will not be able to recover.

(Info: General information about program execution, also useful for the player at time,
Debug: information useful for bug-hunting).

This is more or less my idea about the debug levels. In case of loading the default skin, it is an expected condition that the ground.Outside.pak isn't there, but the pak loading code doesn't know that it is to be expected. Thus for normal pak loading, it is an "error" I assume, for the default skin, "info" or "debug", since it is the expected condition.
Title: Re: Error report for normal operation?
Post by: prissi on February 27, 2012, 09:58:45 PM
Indeed you nailed the history of this error. It should be rather a warning nowadays, since without this file pakset folders wont be recognized at all.
Title: Re: Error report for normal operation?
Post by: Dwachs on February 29, 2012, 10:20:27 AM
partially realized with r 5438.