The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: ArthurDenture on September 08, 2013, 04:05:48 AM

Title: Extract world speed record management into its own class
Post by: ArthurDenture on September 08, 2013, 04:05:48 AM
I noticed that world speed record management in simworld.cc was pretty self-contained, so I wrote up a patch to move it into its own class. See attached.

It's not a huge win, but it's still a nice small improvement: several dozen lines of code and some member variables are removed from simworld.cc.
Title: Re: Extract world speed record management into its own class
Post by: prissi on September 08, 2013, 10:20:09 PM
Why not, incorporated.
Title: Re: Extract world speed record management into its own class
Post by: ArthurDenture on September 08, 2013, 10:51:10 PM
It looks like you might have forgotten an "svn add" on the two new files...

(On the plus side, http://ec2-54-242-171-11.compute-1.amazonaws.com/jenkins/job/simutrans/ caught this :-).)
Title: Re: Extract world speed record management into its own class
Post by: Markohs on September 09, 2013, 09:10:59 AM
Yep, dataobj/records.* is not on svn, prissi

EDIT: Just uploaded them myself @6695, I hope prissi doesn't mind. I also restored the three slashes comments in the .h world records, that way the comments appear in doxygen, you turned them to two slashes, I hope you don't mind it either. :)