The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: Michael 'Cruzer' on September 29, 2014, 11:39:45 AM

Title: [nettool] Using "announce" crashes Simutrans server
Post by: Michael 'Cruzer' on September 29, 2014, 11:39:45 AM
Simutrans revision:
7332 (POSIX build)

Nettool revision:
7332

Issue:
Sending "announce" to server always crashes the server. (Even if you use the wrong password!)

Crash log (Simutrans):

Warning: network_check_activity(): received cmd id=11 nwc_service_t from socket[6]
sim-r7331: simworld.cc:6930: void karte_t::announce_server(int): Assertion `env_t::server && env_t::server_announce' failed.
Title: Re: [nettool] Using "announce" crashes Simutrans server
Post by: prissi on September 30, 2014, 09:08:35 PM
nettool overrides the no annoucement setting. I removed the assertion and allowed this.

However, I would like to have a comment from people using private servers, if that is what they really want.
Title: Re: [nettool] Using "announce" crashes Simutrans server
Post by: Ters on October 01, 2014, 04:35:11 AM
It doesn't sound nice that it is possible to get as far as the reported assert without a correct password in any case.
Title: Re: [nettool] Using "announce" crashes Simutrans server
Post by: Michael 'Cruzer' on October 01, 2014, 02:27:27 PM
Quote from: prissi on September 30, 2014, 09:08:35 PM
nettool overrides the no annoucement setting. I removed the assertion and allowed this.

However, I would like to have a comment from people using private servers, if that is what they really want.
I'm sorry, I don't have any idea why I should manually call "announce" when it does automatically anyway (or not if I don't want so).