The International Simutrans Forum

Development => Bug Reports => Topic started by: xiaopeng on March 23, 2016, 07:22:14 PM

Title: 120.1.3 Factory supplied with all necessary supplies but production is zero
Post by: xiaopeng on March 23, 2016, 07:22:14 PM
Originally posted in the French forum, as I am using some of the addons from the SNFOS site: http://forum.simutrans.com/index.php?topic=13782.msg151139#msg151139

The problem is with a French industry addon--the perfume factory. As the screenshot shows, it is supplied with chemicals, glass, and flowers, but production is zero. Gauthier suggested I repost here as there might be a bug in the game itself.

Details: I'm running 120.1.3 on a Windows 10 laptop. Pak128 with a variety of French and other addons.
Title: Re: 120.1.3 Factory supplied with all necessary supplies but production is zero
Post by: prissi on March 23, 2016, 10:34:45 PM
There was some underflow issue when the new production model JIT2 was patched in. What production model do you use?
Title: Re: 120.1.3 Factory supplied with all necessary supplies but production is zero
Post by: TurfIt on March 23, 2016, 11:23:28 PM
I don't believe zero output storage is supported...
Title: Re: 120.1.3 Factory supplied with all necessary supplies but production is zero
Post by: prissi on March 24, 2016, 12:22:10 AM
Ups, I missed this obvious. Yes, minimum output must be 11 in the default JIT
Title: Re: 120.1.3 Factory supplied with all necessary supplies but production is zero
Post by: DrSuperGood on March 24, 2016, 03:23:22 AM
The factory is producing perfectly. It is correctly stopping when its output is full as intended.

What makes no sense is a factory with 0 output storage. There is no room for it to put any product.

Should loading the pakset of such an impossible factory assert an exception? Or should it try to auto correct to some default value (eg 100 storage)?
Title: Re: 120.1.3 Factory supplied with all necessary supplies but production is zero
Post by: Ters on March 24, 2016, 09:38:18 AM
I'd say that compiling said pak should fail. It is so trivial to check that there is no reason to delay it. If the faulty pak can be expected to circulate for some time to come, doing something at loading time might be an extra feature.
Title: Re: 120.1.3 Factory supplied with all necessary supplies but production is zero
Post by: prissi on March 24, 2016, 10:23:11 PM
I am with Ters, makeobj should fail (or set a default storage and warn).
Title: Re: 120.1.3 Factory supplied with all necessary supplies but production is zero
Post by: gwalch on April 17, 2016, 06:29:06 PM
Ok guys, i've found the mistake ; the parameter [OutputCapacity] was missing into dat file. But makeobj didn't fail at any time (log file was empty).
The new pak file (with correct parameters) is available on SNFOS website.