The International Simutrans Forum

Simutrans Extended => Simutrans-Extended bug reports => Simutrans-Extended development => Simutrans-Extended closed bug reports => Topic started by: Ranran(retired) on June 23, 2018, 11:47:29 AM

Title: Track circuit signal doesn't create directional reservation at specific location
Post by: Ranran(retired) on June 23, 2018, 11:47:29 AM
Track circuit signal doesn't create directional reservation at specific location.

Check this saved game (https://drive.google.com/open?id=1zl6d9Q5Jid2bq6XzIxMewvpAOoVnF3dx) out.
Directional reservation is not created correctly near points k and g2.
(g2 works normally when it goes to north)

(https://i.imgur.com/2xpz9bf.png)

(https://i.imgur.com/zNfkLQX.png)

(https://i.imgur.com/SIhgkRG.png)


I tried to solve this problem in various ways.
- build the station
- put more signals
- change the number of aspects of the signal
- change the signal to bidirectional signal which is at the passing loop

However, the only way that I could solve this was to move the signalbox to another location...
Am I something wrong? (´・ω・`)
Title: Re: Track circuit signal doesn't create directional reservation at specific location
Post by: jamespetts on July 08, 2018, 11:37:45 PM
Thank you for your report - I think that I have managed to fix this. I should be grateful if you could re-test with the next nightly build.
Title: Re: Track circuit signal doesn't create directional reservation at specific location
Post by: Ranran(retired) on July 09, 2018, 11:04:15 AM
Thank you for working on fixing this issue.
I tested running the multiple trains on this line with today's nightly build. As a result, the train frontal collision occurred.(´・ω・`)
I looked for the cause of this, the signal does not create a directional reservation in certain situations.
Although the issue of not making a directional reservation was solved, a directional reservation may end in the middle.


For example, as shown in the following picture, A signal intermediate between i and H does not make a direction reservation when the reservation start signal is k.
This train passes through the station i, so if another train comes from the other side at this time they will collide there.
(https://i.imgur.com/Lh28n1a.png)



the other examples:
(https://i.imgur.com/dEgGDia.png)

(https://i.imgur.com/jRBhBk4.png)

(https://i.imgur.com/VQwRDXC.png)
Title: Re: Track circuit signal doesn't create directional reservation at specific location
Post by: jamespetts on July 09, 2018, 11:17:36 AM
Thank you for testing. Are you able to upload a saved game in which the collision occurs at a specific place and time?
Title: Re: Track circuit signal doesn't create directional reservation at specific location
Post by: Ranran(retired) on July 09, 2018, 09:42:56 PM
QuoteAs a result, the train frontal collision occurred.
I'm apologize. This seems there was a mistake in my signal placement.
By using the two aspects signal instead of the three aspects signal so that the red reservation does not across the passing loop, collision did not occur and it worked correctly.
Title: Re: Track circuit signal doesn't create directional reservation at specific location
Post by: jamespetts on July 09, 2018, 09:50:19 PM
It does not seem to be correct that you need to use only two aspect signals here - I should be grateful if you could upload the saved game demonstrating the collision so that I can try to fix this.
Title: Re: Track circuit signal doesn't create directional reservation at specific location
Post by: Ranran(retired) on July 09, 2018, 10:09:31 PM
Okey. Then, please check this saved game (https://drive.google.com/open?id=1-YG-I_zF6tOfp9qeiF7QhQ8KqbIFSzBT).
I think that this collision can be avoided if it is 2 aspect signal.
Title: Re: Track circuit signal doesn't create directional reservation at specific location
Post by: jamespetts on July 09, 2018, 10:48:18 PM
Thank you for the report/reproduction case: I believe that I have now fixed this. I should be grateful if you could re-test with to-morrow's nightly build.
Title: Re: Track circuit signal doesn't create directional reservation at specific location
Post by: Ranran(retired) on July 10, 2018, 12:07:39 PM
I confirmed that it has been fixed in today's nightly build(#0088b46).
Thank you for fixing this. (´・ω・`)b

However, if there is no problem even if it crosses the passing loop, it is a little concern that the directional reservation indication is interrupted in the middle of the single line section as shown in some pictures above(reply #2), but these blank section can not be reserved from the opposite direction, or the signal can cancel the reservation from the opposite direction.
Therefore the train never collides in their section. That is only display issue.

For example, it does not collision even in a state like this picture. (This is very interesting!)
(https://i.imgur.com/AXVEU8M.png)
Title: Re: Track circuit signal doesn't create directional reservation at specific location
Post by: jamespetts on July 10, 2018, 12:48:42 PM
Thank you for confirming. The single tile gap should not create issues as there is no way in which this can ever be reserved, so this can be regarded as fixed.