The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: Ranran(retired) on December 22, 2018, 02:24:12 AM

Title: Bug: Line management icon disappears from main menu bar when lock the player
Post by: Ranran(retired) on December 22, 2018, 02:24:12 AM
Line management icon disappears from main menu bar when disallow player changes.

(https://i.imgur.com/4ygFBZJ.png)
Oops, where is the icon? (´・ω・`)
There should have been Line management icon in the place indicated by the red arrow.
You can use the shortcut key though.

EDIT:
This seems to be caused by the Map Editing Tools icon was there.
Locking the player will switch public player to the nomal player, but the Line management icon will not revive and the Map Editing Tools icon will be banished.
After saving and reloading or restarting the game, the line management icon will revive.

EDIT2:
Sorry I jumped to conclusion, this seems to be a bug originated from standard.
Title: Re: Bug: Line management icon disappears from main menu bar when lock the player
Post by: jamespetts on December 22, 2018, 11:53:14 PM
Thank you very much for looking into this: that is most helpful. You have discovered, I note, that this bug comes from Standard. May I ask whether there is a fix in Standard for it that has been published yet? If so, it might be worth implementing that.
Title: Re: Bug: Line management icon disappears from main menu bar when lock the player
Post by: Ranran(retired) on December 24, 2018, 09:57:18 PM
I found that the icon will revive at the beginning of the next month(in-game).
This is the same behavior for both Standard and Extended.
Title: Re: Bug: Line management icon disappears from main menu bar when lock the player
Post by: jamespetts on December 24, 2018, 10:12:54 PM
I have moved this to the general bug reports section as this has been confirmed to be able to be reproduced in Standard.
Title: Re: Bug: Line management icon disappears from main menu bar when lock the player
Post by: prissi on December 25, 2018, 01:41:17 AM
That must be there for ages. Fixed in r8647, was a wrong order of calls. (It rather shows that this function did not saw much use in the last 10 years ... ) But anyway, locking a game is for saving and then do offline competitions. So a reload is almost certainly involved in that procedure.