The International Simutrans Forum

Development => Patches & Projects => Denied Requests & Patches => Topic started by: Yona-TYT on July 14, 2019, 03:48:28 PM

Title: Images of vehicles no longer appear in "message center"
Post by: Yona-TYT on July 14, 2019, 03:48:28 PM


The image of the vehicles should appear when you open a message of: New vehicle now available: "vehicle name"

I was testing the scenario tutorial, and I noticed this error, I guess it was when I updated the code of the gui.
Title: Re: Images of vehicles no longer appear in "message center"
Post by: Dwachs on July 15, 2019, 06:30:33 AM
Which version/revision of the program is affected?
Title: Re: Images of vehicles no longer appear in "message center"
Post by: Yona-TYT on July 15, 2019, 06:33:42 AM
Simutrans 120.4.1 r8776
Title: Re: Images of vehicles no longer appear in "message center"
Post by: Dwachs on July 20, 2019, 09:46:43 AM
I cannot reproduce this
Title: Re: Images of vehicles no longer appear in "message center"
Post by: Yona-TYT on July 20, 2019, 04:37:55 PM
Quote from: Dwachs on July 20, 2019, 09:46:43 AM I cannot reproduce this
Quote from: Dwachs on July 20, 2019, 09:46:43 AM I cannot reproduce this
It seems that the first 6 or 7 messages on the list show the images correctly, the rest do not
Title: Re: Images of vehicles no longer appear in "message center"
Post by: Yona-TYT on July 21, 2019, 10:27:26 PM
Maybe it's just in my savegame.

You can check this:
Tutorial3.sve (http://www.mediafire.com/file/yqrw13jujj4u42h/Tutorial3.sve/file)
Title: Re: Images of vehicles no longer appear in "message center"
Post by: Yona-TYT on September 22, 2019, 07:53:53 PM
Now I can replicate the problem!

It turns out that if the message is opened for the first time, the image of the vehicle appears normally.

To replicate save the game, load savegame again and when opening the message the image is no longer displayed.

Edit.
The error is that the message is duplicated when the game is saved and loaded again.
Title: Re: Images of vehicles no longer appear in "message center"
Post by: Dwachs on October 09, 2019, 03:55:58 PM
Saving & reloading messages loses the information about image. This is hard to fix.
Title: Re: Images of vehicles no longer appear in "message center"
Post by: Yona-TYT on October 15, 2019, 02:24:09 AM
I have saved and loaded a savegame 10 times, and the result was 10 messages repeated in the "message center".  :o :o :o :o

Savegame: https://www.mediafire.com/file/7qts42tkl5znnv2/replicate.sve/file (https://www.mediafire.com/file/7qts42tkl5znnv2/replicate.sve/file)

Title: Re: Images of vehicles no longer appear in "message center"
Post by: prissi on October 15, 2019, 11:48:27 AM
I presume you just save moments before retirement.
Title: Re: Images of vehicles no longer appear in "message center"
Post by: Ters on October 15, 2019, 02:26:22 PM
When you load a game, generation of all timeline related messages valid for the current month will be triggered. So if you save and load a game nine times during a single game month, you get ten messages. Nice to have in case the month changed right before you saved. Otherwise, one might miss them. Especially if using autosave on close.