The International Simutrans Forum

Simutrans Extended => Patches/pull requests for consideration => Simutrans-Extended development => Incorporated patches/merged pull requests => Topic started by: Ranran(retired) on May 21, 2020, 02:17:40 PM

Title: Juiced up minimap goods category filter
Post by: Ranran(retired) on May 21, 2020, 02:17:40 PM
Welcome to Ranran's laboratory. (´・ω・`)
Today I brought a new patch prototype.

(https://i.imgur.com/HrHv427.gif)

Enhance goods category filter in minimap.
Link with existing filters to remove extraneous factories from the minimap.
This makes it easy to find a factory near your network where you can pick up cargo.

I would appreciate your feedback. See you in the next experiment. (´・ω・`)らんらん♪
Title: Re: Juiced up minimap goods category filter
Post by: Vladki on May 21, 2020, 02:42:41 PM
Looks good - especially for games like bridgewater ;)
Title: Re: Juiced up minimap goods category filter
Post by: Mariculous on May 21, 2020, 03:46:12 PM
Oh, from the title I thought you added "good categories" for passenger classes.

Anyways, that's very useful and consistent to other layers now, i.e. use the filters for layers, wher that makes sense.
Title: Re: Juiced up minimap goods category filter
Post by: jamespetts on May 22, 2020, 03:59:33 PM
This looks like a good addition - but may I ask what the branch name is for this so that I can test it?
Title: Re: Juiced up minimap goods category filter
Post by: Ranran(retired) on May 22, 2020, 04:02:56 PM
Quote from: jamespetts on May 22, 2020, 03:59:33 PMbut may I ask what the branch name is for this so that I can test it?
Here it is.
https://github.com/Ranran-the-JuicyPork/simutrans-extended/tree/minimap-plus
Title: Re: Juiced up minimap goods category filter
Post by: jamespetts on May 22, 2020, 04:20:36 PM
Excellent, now incorporated.

There is one refinement that needs to be considered, however: currently, when "passengers" or "mail" is selected, no industries are shown, even though the industries do in fact accept/generate passengers and mail. May I suggest that all industries that accept passengers show when the "passengers" filter is active and all industries that accept/generate mail show when the "mail" filter is active?

Thank you for your work on this.
Title: Re: Juiced up minimap goods category filter
Post by: Ranran(retired) on May 22, 2020, 04:43:25 PM
QuoteMay I suggest that all industries that accept passengers show when the "passengers" filter is active and all industries that accept/generate mail show when the "mail" filter is active?
Does that mean that the factory has a demand? Or is it to have an output boost by passenger or mail?
In the former case, I think that almost all of them have demand. For passengers, there may be few visitors, but there is worker demand.
Title: Re: Juiced up minimap goods category filter
Post by: jamespetts on May 22, 2020, 04:53:43 PM
Quote from: Ranran on May 22, 2020, 04:43:25 PM
Does that mean that the factory has a demand? Or is it to have an output boost by passenger or mail?
In the former case, I think that almost all of them have demand. For passengers, there may be few visitors, but there is worker demand.

Yes, I do mean a demand: almost all, but not quite all, industries have a passenger demand for workers. Fisheries, for example, have no passenger demand. It does make sense to list all industries with a passenger demand if one selects "passenger" so that players wanting to serve industries with passengers know which ones are available for this purpose, and likewise mail.
Title: Re: Juiced up minimap goods category filter
Post by: Ranran(retired) on May 22, 2020, 11:56:55 PM
Quote from: jamespetts on May 22, 2020, 04:53:43 PMFisheries, for example, have no passenger demand. It does make sense to list all industries with a passenger demand if one selects "passenger" so that players wanting to serve industries with passengers know which ones are available for this purpose, and likewise mail.
Thank you for the explanation. I fixed it and updated "minimup-plus" branch.
Title: Re: Juiced up minimap goods category filter
Post by: jamespetts on May 23, 2020, 05:31:54 PM
Splendid, thank you: now incorporated.