The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: m.vanderwulp on October 13, 2020, 05:44:40 PM

Title: Themes folder in release 122.0 is broken
Post by: m.vanderwulp on October 13, 2020, 05:44:40 PM
I am trying to build a update of the RPM for the openSUSE repositories for the recent 122.0 version, but run into a problem.

See https://build.opensuse.org/package/show/home:m_vanderwulp:branches:games/simutrans

Starting simutrans when installed from this new RPM, I get:


Use work dir /usr/share/simutrans/
Reading low level config data ...
parse_simuconf() at config/simuconf.tab: Reading simuconf.tab successful!
SDL Driver: x11
Init done.
FATAL ERROR: gui_theme_t::init_gui_themes - Wrong theme loaded
Aborting program execution ...
For help with this error or to file a bug report please see the Simutrans forum at http://forum.simutrans.com
Aborted (core dumped)


I think that this is caused by an incompleteness in the themes folder: there is no ".pak" file present in this folder in the simutrans-src zip, this in contrast to the 121 release.

Is there something I do wrong? Any solution?
Title: Re: Themes folder in release 122.0 is broken
Post by: CannonBall7 on October 13, 2020, 09:26:24 PM
Have a look at the changes I made for the Homebrew formula[1], where it enters themes.src/ and symlinks makeobj before running build_themes.sh.

1: https://github.com/Homebrew/homebrew-core/pull/62813 (https://github.com/Homebrew/homebrew-core/pull/62813)
Title: Re: Themes folder in release 122.0 is broken
Post by: prissi on October 14, 2020, 02:10:30 AM
The binary paks are already contributed with Simutrans, so I fail to see the need to buuild them from source.

By the way, I think brew should distribute freetype enabled builds, since without scalable fonts simutrans in almost unplayable on modern 2K screens and larger.
Title: Re: Themes folder in release 122.0 is broken
Post by: Ters on October 14, 2020, 05:07:06 PM
Quote from: prissi on October 14, 2020, 02:10:30 AMThe binary paks are already contributed with Simutrans, so I fail to see the need to buuild them from source.
Some distros want to link against the version of the libraries they use, so that they know they are compatible, and up-to-date.
Title: Re: Themes folder in release 122.0 is broken
Post by: prissi on October 15, 2020, 01:53:15 AM
I mean the binary "xxx.pak" files
Title: Re: Themes folder in release 122.0 is broken
Post by: Ters on October 17, 2020, 02:03:03 PM
The rules can likely be all or nothing to keep them simple. Or misunderstood to be that way.