The International Simutrans Forum

Simutrans Extended => Patches/pull requests for consideration => Simutrans-Extended development => Incorporated patches/merged pull requests => Topic started by: Ranran(retired) on January 07, 2021, 10:22:28 AM

Title: Pull request: touch up the halt detail dialog
Post by: Ranran(retired) on January 07, 2021, 10:22:28 AM
(1) Change some tabs to new code style

(2) Bug fix
Quote from: Ranran on December 18, 2020, 09:27:06 AMI'm aware of a scrollbar issue, but I haven't fixed it yet.
Quote from: freddyhayward on December 19, 2020, 11:46:24 AM3. The list cannot be scrolled. I believe you said you were aware of this.

(3) Add information and symbolize on the service tab

and fixed minor sizing mistakes

Before:
(https://i.imgur.com/vasOgu6.png)


After:
(https://i.imgur.com/MkcKttp.png)

Well, the handling goods category may be more useful than the display of convoy numbers. (´・ω・`)

Check pull request #333.

Thank you. (´・ω・`)
Title: Re: Pull request: touch up the halt detail dialog
Post by: jamespetts on January 07, 2021, 02:16:53 PM
Thank you - now incorporated.
Title: Re: Pull request: touch up the halt detail dialog
Post by: Ranran(retired) on January 07, 2021, 03:23:52 PM
Sorry to bother you again. (´・ω・`)
I noticed that the Local passenger demand numbers are incorrect. The cause was that I was counting multi-tile buildings multiple times.
I have fixed it. Please check pull request #334.
Title: Re: Pull request: touch up the halt detail dialog
Post by: jamespetts on January 07, 2021, 03:41:44 PM
Excellent, thank you. Now incorporated.
Title: Re: Pull request: touch up the halt detail dialog
Post by: freddyhayward on January 08, 2021, 06:38:35 AM
I had another segfault after clicking 'low' in the routes display for a stop where I had recently altered the line.
Title: Re: Pull request: touch up the halt detail dialog
Post by: Ranran(retired) on January 08, 2021, 08:38:23 AM
Quote from: freddyhayward on January 08, 2021, 06:38:35 AMI had another segfault after clicking 'low' in the routes display for a stop where I had recently altered the line.
Thank your for your report. I think I've fixed it. Please check pull request #335.
Title: Re: Pull request: touch up the halt detail dialog
Post by: jamespetts on January 08, 2021, 11:10:46 AM
Quote from: Ranran on January 08, 2021, 08:38:23 AM
Thank your for your report. I think I've fixed it. Please check pull request #335.

Thank you - now incorporated.