The International Simutrans Forum

Development => Bug Reports => Known bugs and features => Topic started by: THLeaderH on January 09, 2021, 12:27:36 PM

Title: [r9531] script tool icon is not shown when menu key contains ")"
Post by: THLeaderH on January 09, 2021, 12:27:36 PM
In r9531, the script tool icon is not shown in menubar when the menu key of the script tool contains ")" character. This is just a parsing problem and should be fixed with the attached patch.
Title: Re: [r9531] script tool icon is not shown when menu key contains ")"
Post by: prissi on January 09, 2021, 12:36:30 PM
I do not think that get_sound will work with that too. So maybe a little more effort is needed. Still submitted this, thank you.
Title: Re: [r9531] script tool icon is not shown when menu key contains ")"
Post by: THLeaderH on January 09, 2021, 01:16:25 PM
script_tool_manager_t::fill_menu() does not take sound parameter. To be precise, the function ignores the sound argument.
Title: Re: [r9531] script tool icon is not shown when menu key contains ")"
Post by: prissi on January 09, 2021, 01:50:10 PM
But it should be possible to connect a sound to it, I think.
Title: Re: [r9531] script tool icon is not shown when menu key contains ")"
Post by: Dwachs on January 09, 2021, 02:55:55 PM
This parameter is ignored in all these fill_menu methods.
Title: Re: [r9531] script tool icon is not shown when menu key contains ")"
Post by: prissi on January 10, 2021, 12:12:32 PM
Probably the get_sound() call should go then as well. Although building definitively makes noise.