The International Simutrans Forum

Simutrans Extended => Patches/pull requests for consideration => Simutrans-Extended development => Incorporated patches/merged pull requests => Topic started by: freddyhayward on September 18, 2021, 10:40:29 AM

Title: New debug sums to monitor car/pedestrian randomness
Post by: freddyhayward on September 18, 2021, 10:40:29 AM
The purpose of this pull request is to help track down frequent desyncs occurring at some point during the sync_step. My hypothesis is that there is a discrepancy in the random behaviour of cars or pedestrians. If this is correct, then we would observe differences in these new sums which would help to further isolate the problem. If not, another approach will have to be found.

These sums replace the existing sums at [8] & [9] counting the number of sync objects, which didn't seem to correspond to any recent desyncs.

The pull request can be found here: https://github.com/jamespetts/simutrans-extended/pull/445
Title: Re: New debug sums to monitor car/pedestrian randomness
Post by: jamespetts on September 18, 2021, 10:45:24 AM
Excellent, now incorporated. Thank you for your work on this.
Title: Re: New debug sums to monitor car/pedestrian randomness
Post by: freddyhayward on September 18, 2021, 10:59:01 AM
Quote from: jamespetts on September 18, 2021, 10:45:24 AM
Excellent, now incorporated. Thank you for your work on this.
It doesn't seem to have been incorporated yet. Was this intentional?
Title: Re: New debug sums to monitor car/pedestrian randomness
Post by: jamespetts on September 18, 2021, 11:00:36 AM
Quote from: freddyhayward on September 18, 2021, 10:59:01 AM
It doesn't seem to have been incorporated yet. Was this intentional?

Oops - forgot to push. Now done.
Title: Re: New debug sums to monitor car/pedestrian randomness
Post by: prissi on September 18, 2021, 12:48:04 PM
If it is as standard, the eye-candy like clouds and pedestrians should not affect the random state.
Title: Re: New debug sums to monitor car/pedestrian randomness
Post by: freddyhayward on September 19, 2021, 07:41:45 AM
Quote from: prissi on September 18, 2021, 12:48:04 PMIf it is as standard, the eye-candy like clouds and pedestrians should not affect the random state.
I don't know why, but extended pedestrians do affect the random state.